Skip to content

feat(ble): introduce Kconfig option to disable Bluetooth profile advertising #2188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
xudongzheng wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(ble): introduce Kconfig option to disable Bluetooth profile advertising #2188

xudongzheng wants to merge 1 commit into from
+11 −0

Conversation

@xudongzheng
Copy link
Contributor

@xudongzheng xudongzheng commented Mar 7, 2024 •
edited
Loading

CONFIG_ZMK_BLE_PROFILE_ADVERTISING=n can be used to disable profile advertising.

@xudongzheng xudongzheng requested a review from a team as a code owner March 7, 2024 04:35
@xudongzheng xudongzheng force-pushed the bt-no-profile-pr branch 2 times, most recently from 17b001b to 928f82a Compare August 6, 2024 17:57
ayroblu
ayroblu approved these changes Feb 11, 2025
View reviewed changes
Copy link

@ayroblu ayroblu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested and verified this works
ayroblu/zmk-config@fc90095...ce2691a
My keyboard types fine, and I no longer see my dongle advertising in bluetooth settings

@xudongzheng xudongzheng changed the title feat(ble): allow dongle without Bluetooth profiles feat(ble): introduce Kconfig option to disable Bluetooth profile advertising Feb 21, 2025
@xudongzheng
Copy link
Contributor Author

xudongzheng commented Feb 21, 2025

This PR has been reworked such that profile advertising can be disabled with CONFIG_ZMK_BLE_PROFILE_ADVERTISING=n.

This makes configuration slightly less error prone as the user no longer has to make changes to CONFIG_BT_MAX_CONN, since the value ends up being different for dongle and dongleless.

Additionally, some parts of ZMK make the assumption that the number of profiles is non-zero. Having CONFIG_ZMK_SPLIT_BLE_CENTRAL_PERIPHERALS set to CONFIG_BT_MAX_CONN can cause ZMK to behave unexpectedly as a result of that.

@github-actions
Copy link

github-actions bot commented Jan 18, 2026

This PR has been automatically marked as stale because it has not had activity in 10 months. It will be closed in 14 days if no further activity occurs. Feel free to give a status update or re-open when it has been rebased and is ready for review (again). Thanks!

@github-actions github-actions bot added the Stale label Jan 18, 2026
@xudongzheng
feat(ble): introduce Kconfig option to disable Bluetooth profile adve…
daa33dc 
…rtising

This is useful for dongle mode with only USB output.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@ayroblu ayroblu ayroblu approved these changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

Stale

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@xudongzheng @ayroblu