-
Notifications
You must be signed in to change notification settings - Fork 0
Deps #21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
agalin920
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shrunyan How are we determining whether to hit stage url or prod url? Or are we defaulting to to one?
The domain selection is a nextjs specific detail and so it is contained within the nextjs-sync lib. https://github.com/zesty-io/nextjs-sync/blob/main/src/fetchPageJson.js#L20 |
|
@shrunyan Sweet. Thanks |
…upport. Catch all refactor
|
To solve for a user being able to run sync without being logged in or the presence of the For model ignore I'll add another env var. The logic changes will be made in https://github.com/zesty-io/nextjs-sync |
|
@shrunyan @agalin920 i merged this to get the latest README in, @shrunyan I'd still like to see changes to zesty config setup |
Update starter to use extracted package. https://github.com/zesty-io/nextjs-sync
The starter will only be aware of the nextjs-sync package. The nextjs-sync package depends on a few others which have been either extracted or improved. This complete stack of dependencies is required for that starter to operate.
These changes introduce a signficant change in how environment variables are handled. Moving from a custom
zesty.config.jsfile to the standard nextjs.envfile.It also abandons a few unnecessary variables.
src_diris not necessary as nextjs only allows root orsrc. So instead opt to behave similarly to nextjs and determine which one the user has decided on by inspecting the file systemAdditionally a few values are now derived and require no user action to setup.
Other variables have been moved from the prior
zesty.config.jsfile into the cli managed.zesty/config.jsfile. Consolidating where zesty configurations occur.