allow numpy ints in shapelike #3706
Merged
+22
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
needs release notes
github-actions
bot
removed
the
needs release notes
maxrjones
reviewed
Feb 12, 2026
Comment on lines
196
to
200
| try: | ||
| data_tuple = tuple(data) | ||
| except TypeError as e: | ||
| msg = f"Expected an integer or an iterable of integers. Got {data} instead." | ||
| raise TypeError(msg) from e |
Member
There was a problem hiding this comment.
could this be consolidated with L210?
Contributor
Author
There was a problem hiding this comment.
there's invalid stuff (dict keys, strings) that could come out of an iterable data and be converted to int without any error. If data is ["0", "1"], then tuple(int(x) for x in data) will not error, and then we are accepting strings as shapes, which I didn't want to do here. So I think we need to end up calling tuple twice.
maxrjones
approved these changes
Feb 12, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #3680