Allow default values to be None (missing) for spatial convention#14
Open
kylebarron wants to merge 1 commit intozarr-developers:mainfrom
Open
Allow default values to be None (missing) for spatial convention#14kylebarron wants to merge 1 commit intozarr-developers:mainfrom
None (missing) for spatial convention#14kylebarron wants to merge 1 commit intozarr-developers:mainfrom
Conversation
✅ Deploy Preview for geozarrdemonstration4e8c9 canceled.
|
kylebarron
changed the title
None (missing) for spatial convention
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since the spec explicitly allows for
transform_typeandregistrationto be missing, it seems like we should allow that as well in the toolkit. Currently, there's no way for the user to create missing keys.This changes the default values of
transform_typeandregistrationto beNone, in line with the defaults in the spec.(For the record, I would be happy to be explicit in the spec that
transform_type: "affine"must be set and thatregistration: "pixel"must be set, but that would be a backwards incompatible change)