PDE-6714 chore: more cleanup on pnpm switch #1209
Conversation
| run: pnpm smoke-test | ||
| working-directory: packages/cli | ||
| - name: Test npx resolution | ||
| run: npx . --version |
There was a problem hiding this comment.
The command was npx zapier-platform-cli --version originally. I removed it in #1204 because it was always running the latest package version on the npm registry, and I didn't know how to get it to run the version in the local repo—until now. It's actually easy to tell npx to run the local version in the repo. Just use npx ..
| "bump": "./scripts/bump.js", | ||
| "prepare": "husky", | ||
| "generate-types": "cd schema-to-ts && pnpm generate-types", | ||
| "preinstall": "npx only-allow pnpm" |
There was a problem hiding this comment.
This is replaced by the ignore-scripts option in .npmrc and .yarnrc.
| @@ -0,0 +1,3 @@ | |||
| # This project uses pnpm, but just in case npm is used, we want to avoid running | |||
| # pre/post install scripts by accident. | |||
| ignore-scripts = true | |||
There was a problem hiding this comment.
This broke the should build with ssh2 with .node files test. Not sure if there's a way to allow scripts only for certain packages. 🤔
There was a problem hiding this comment.
Ended up using two npm install commands to solve this.
npm install --ignore-scripts false [email protected]
npm install --ignore-scripts
See e03159d for detail.
2 participants
Following up on #1204, this PR further cleans up some unused stuff after switching to pnpm.