Negative indentLevel throwing RangeError when prettyPrinting#73
Open
lathonez wants to merge 1 commit intozaach:masterfrom
lathonez:master
Open
Negative indentLevel throwing RangeError when prettyPrinting#73lathonez wants to merge 1 commit intozaach:masterfrom lathonez:master
lathonez wants to merge 1 commit intozaach:masterfrom
lathonez:master
Conversation
…y length - force count to zero if negative
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Believe it or not this is from a real world example. Found on http://pro.jsonlint.com and followed back here.
Simplest replication I can find:
Without pretty printing it works fine as the formatter isn't used:
My fix is to force the count value to zero inside jsl.format.repeat if it happens to be negative, which gives the following output: