Restore config_params for cache_ttl and definitions. Restore default value for port config_params.#4
Open
seabre wants to merge 1 commit intoyvesbd:masterfrom
Open
Restore config_params for cache_ttl and definitions. Restore default value for port config_params.#4seabre wants to merge 1 commit intoyvesbd:masterfrom
seabre wants to merge 1 commit intoyvesbd:masterfrom
Conversation
… from source config. Restore defaults to port param.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For some reason, in b5aa9fa, the
config_paramsforcache_ttlanddefinitionswere removed.This patch adds them back, which appears to fix #1 and fix #3.
Note: Also switches affected change to Ruby 1.9 hash syntax.