Some refactors #14

MykhailoDav · 2025-11-26T13:57:58Z

…lementChildrenChanging constructor

…y and consistency; update access modifiers and formatting

…ifiers and formatting across multiple files

Copilot

Pull request overview

This PR refactors the codebase for consistency and adds development guidelines. It includes:

Addition of GitHub Copilot prompts and instructions for contributors
Introduction of an .editorconfig file with coding standards
Code refactoring across handlers and samples to align with new standards (access modifiers, field naming, formatting)

Reviewed changes

Copilot reviewed 27 out of 28 changed files in this pull request and generated 13 comments.

Show a summary per file

File	Description
Handler files (iOS, MacCatalyst, Android)	Added explicit `private` access modifiers to methods and fields; reformatted code for consistency
AppHostBuilderExtensions.cs	Converted to file-scoped namespace and updated handler registration syntax
SegmentedControlOption.cs	Updated field naming from underscore-prefix to camelCase; changed to file-scoped namespace
SegmentedControl.cs, ISegmentedControl.cs	Applied formatting consistency; changed to file-scoped namespace
GroupToggleBehavior.cs, ElementChildrenChanging.cs	Converted to file-scoped namespace; used primary constructor
Test2ViewModel.cs	Refactored field naming to camelCase; converted to file-scoped namespace; used collection expressions
Sample code-behind files	Updated field naming and access modifiers to match editorconfig rules
.editorconfig	Added comprehensive coding standards including naming rules, analyzers, and formatting preferences
Copilot prompt files	Added coding guidelines, best practices, and testing patterns

Comments suppressed due to low confidence (1)

samples/SegmentedControlSamples/SegControlTest1.xaml.cs:70

Both branches of this 'if' statement write to the same variable - consider using '?' to express intent better.

        if (SegmentedControl.SelectedTextColor != Colors.Red)
        {
            SegmentedControl.SelectedTextColor = Colors.Red;
        }
        else
        {
            SegmentedControl.SelectedTextColor = Colors.Green;
        }

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

src/Plugin.Maui.SegmentedControl/Control/SegmentedControlOption.cs

samples/SegmentedControlSamples/Test2ViewModel.cs

.github/copilot-instructions.md

samples/SegmentedControlSamples/SegControlTest1.xaml.cs

samples/SegmentedControlSamples/SegControlTest2.xaml.cs

samples/SegmentedControlSamples/SegControlTest1.xaml.cs

samples/SegmentedControlSamples/Test2ViewModel.cs

Copilot · 2025-11-26T14:53:32Z

@MykhailoDav I've opened a new pull request, #15, to work on those changes. Once the pull request is ready, I'll request review from you.

…n.cs Co-authored-by: Copilot <[email protected]>

Co-authored-by: Copilot <[email protected]>

…olTest1 constructor

…gmentedControl into Refactors

Co-authored-by: Copilot <[email protected]>

…st2ViewModel

…n constructor for improved logging consistency

…gmentedControl into Refactors

Copilot

Pull request overview

Copilot reviewed 27 out of 28 changed files in this pull request and generated 8 comments.

Comments suppressed due to low confidence (1)

samples/SegmentedControlSamples/SegControlTest1.xaml.cs:62

Both branches of this 'if' statement write to the same variable - consider using '?' to express intent better.

        if (SegmentedControl.SelectedTextColor != Colors.Red)
        {
            SegmentedControl.SelectedTextColor = Colors.Red;
        }
        else
        {
            SegmentedControl.SelectedTextColor = Colors.Green;
        }

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-11-26T17:05:04Z

samples/SegmentedControlSamples/SegControlTest2.xaml.cs

+    Test2ViewModel viewModel;

    public SegControlTest2()
    {
        InitializeComponent();
-        
-        SegmentedControl.BindingContext = _viewModel = new Test2ViewModel();
+
+        SegmentedControl.BindingContext = viewModel = new Test2ViewModel();
    }

-    private void SegmentedControl_ValueChanged(object sender, Plugin.Maui.SegmentedControl.ValueChangedEventArgs e)
+    void SegmentedControl_ValueChanged(object sender, Plugin.Maui.SegmentedControl.ValueChangedEventArgs e)
    {
        segmentIndexLabel.Text = e.NewValue.ToString();
    }

-    PlayerStatus _playerStatus = PlayerStatus.Stopped;
-    private void SegmentedControl_SegmentTapped(object sender, SegmentTappedEventArgs e)
+    PlayerStatus playerStatus = PlayerStatus.Stopped;
+    void SegmentedControl_SegmentTapped(object sender, SegmentTappedEventArgs e)
    {
        if (e.Index == 1)
        {
-            if (_playerStatus == PlayerStatus.Playing)
+            if (playerStatus == PlayerStatus.Playing)
            {
                SegmentedControl.Children[1].Text = "Play";
-                _playerStatus = PlayerStatus.Stopped;
+                playerStatus = PlayerStatus.Stopped;
            }
            else
            {
                SegmentedControl.Children[1].Text = "Stop";
-                _playerStatus = PlayerStatus.Playing;
+                playerStatus = PlayerStatus.Playing;
            }
        }


The private modifiers added to fields and methods contradict the project's coding guidelines. According to .github/copilot-instructions.md line 128: "We do not use the private keyword as it is the default accessibility level in C#."

These access modifiers should be removed.

@copilot open a new pull request to apply changes based on this feedback

Copilot · 2025-11-26T17:05:04Z

samples/SegmentedControlSamples/Test2ViewModel.cs

+    PlayerStatus playerStatus;
+    PlayerStatus PlayerStatus
+    {
+        get { return playerStatus; }
+        set
        {
-            get { return this.PlayerStatus.ToString(); }
+            playerStatus = value;
+            OnPropertyChanged(new PropertyChangedEventArgs(nameof(PlayerStatusText)));
+            PlayButtonText = playerStatus == PlayerStatus.Playing ? "STOP" : "Play";
        }
+    }

-        private string _playButtonText;
-        public string PlayButtonText
-        {
-            get => _playButtonText;
-            set { _playButtonText = value; OnPropertyChanged(new PropertyChangedEventArgs(nameof(PlayButtonText))); }
-        }
+    public string PlayerStatusText
+    {
+        get { return PlayerStatus.ToString(); }
+    }

-        private bool _backButtonEnabled = true;
-        public bool BackButtonEnabled
-        {
-            get => _backButtonEnabled;
-            set { _backButtonEnabled = value; OnPropertyChanged(new PropertyChangedEventArgs(nameof(BackButtonEnabled))); }
-        }
+    string playButtonText;
+    public string PlayButtonText
+    {
+        get => playButtonText;
+        set { playButtonText = value; OnPropertyChanged(new PropertyChangedEventArgs(nameof(PlayButtonText))); }
+    }

-        private bool _forwardButtonEnabled = true;
-        public bool ForwardButtonEnabled
-        {
-            get => _forwardButtonEnabled;
-            set { _forwardButtonEnabled = value; OnPropertyChanged(new PropertyChangedEventArgs(nameof(ForwardButtonEnabled))); }
-        }
+    bool backButtonEnabled = true;
+    public bool BackButtonEnabled
+    {
+        get => backButtonEnabled;
+        set { backButtonEnabled = value; OnPropertyChanged(new PropertyChangedEventArgs(nameof(BackButtonEnabled))); }
+    }

-        private string _forwardButtonText;
-        public string ForwardButtonText
-        {
-            get => _forwardButtonText;
-            set { _forwardButtonText = value; OnPropertyChanged(new PropertyChangedEventArgs(nameof(ForwardButtonText))); }
-        }
+    bool forwardButtonEnabled = true;
+    public bool ForwardButtonEnabled
+    {
+        get => forwardButtonEnabled;
+        set { forwardButtonEnabled = value; OnPropertyChanged(new PropertyChangedEventArgs(nameof(ForwardButtonEnabled))); }
+    }

+    string forwardButtonText;
+    public string ForwardButtonText
+    {
+        get => forwardButtonText;
+        set { forwardButtonText = value; OnPropertyChanged(new PropertyChangedEventArgs(nameof(ForwardButtonText))); }
+    }

-        private int _selectedSegment;
-        public int SelectedSegment
-        {
-            get => _selectedSegment;
-            set
-            {
-                _selectedSegment = value;
-                OnPropertyChanged(new PropertyChangedEventArgs(nameof(SelectedSegment)));
-            }
-        }
-        private IList<SegmentedControlOption> _segmentItemsSource;
-        public IList<SegmentedControlOption> SegmentItemsSource
+    int selectedSegment;
+    public int SelectedSegment
+    {
+        get => selectedSegment;
+        set
        {
-            get => _segmentItemsSource;
-            set { _segmentItemsSource = value; OnPropertyChanged(new PropertyChangedEventArgs(nameof(SegmentItemsSource))); }
+            selectedSegment = value;
+            OnPropertyChanged(new PropertyChangedEventArgs(nameof(SelectedSegment)));
        }
+    }

-
-        public event PropertyChangedEventHandler PropertyChanged;
-        protected virtual void OnPropertyChanged(PropertyChangedEventArgs e)
-        {
-            PropertyChanged?.Invoke(this, e);
-        }
+    IList<SegmentedControlOption> segmentItemsSource;
+    public IList<SegmentedControlOption> SegmentItemsSource
+    {
+        get => segmentItemsSource;
+        set { segmentItemsSource = value; OnPropertyChanged(new PropertyChangedEventArgs(nameof(SegmentItemsSource))); }
    }


The private modifiers added to fields contradict the project's coding guidelines. According to .github/copilot-instructions.md line 128: "We do not use the private keyword as it is the default accessibility level in C#."

These access modifiers should be removed.

@copilot open a new pull request to apply changes based on this feedback

samples/SegmentedControlSamples/.editorconfig

Copilot · 2025-11-26T17:05:05Z

src/Plugin.Maui.SegmentedControl/Control/SegmentedControlOption.cs

+    private SegmentedControl parent;

-    int _instanceId;
+    private readonly int instanceId;


The private modifiers added to fields contradict the project's coding guidelines. According to .github/copilot-instructions.md line 128: "We do not use the private keyword as it is the default accessibility level in C#."

These access modifiers should be removed.

@copilot open a new pull request to apply changes based on this feedback

Copilot · 2025-11-26T17:06:08Z

@yurkinh I've opened a new pull request, #16, to work on those changes. Once the pull request is ready, I'll request review from you.

Copilot · 2025-11-26T17:06:17Z

@yurkinh I've opened a new pull request, #17, to work on those changes. Once the pull request is ready, I'll request review from you.

Copilot · 2025-11-26T17:06:21Z

@yurkinh I've opened a new pull request, #18, to work on those changes. Once the pull request is ready, I'll request review from you.

Copilot · 2025-11-26T17:06:21Z

@yurkinh I've opened a new pull request, #19, to work on those changes. Once the pull request is ready, I'll request review from you.

Copilot · 2025-11-26T17:06:57Z

@yurkinh I've opened a new pull request, #20, to work on those changes. Once the pull request is ready, I'll request review from you.

Copilot · 2025-11-26T17:07:19Z

@yurkinh I've opened a new pull request, #21, to work on those changes. Once the pull request is ready, I'll request review from you.

Copilot · 2025-11-26T17:08:08Z

@yurkinh I've opened a new pull request, #22, to work on those changes. Once the pull request is ready, I'll request review from you.

Co-authored-by: yurkinh <[email protected]>

… coding guidelines Co-authored-by: yurkinh <[email protected]>

Co-authored-by: yurkinh <[email protected]>

Remove private keyword from fields per coding guidelines

[WIP] Address feedback from review on some refactors PR

Co-authored-by: yurkinh <[email protected]>

…d75-8222-2696c59534da Remove private modifiers per coding guidelines

No changes needed - typo already corrected

Verify removal of private modifiers in Test2ViewModel.cs

Address coding guidelines feedback - private modifiers already removed

MykhailoDav added 6 commits November 26, 2025 15:35

Refactor SegControlTest1 and Test2ViewModel for consistency; update E…

fff724f

…lementChildrenChanging constructor

Added Copilot promts

7d3423e

added editorconfig

232e663

Refactor SegmentedControl and related classes for improved readabilit…

81164ce

…y and consistency; update access modifiers and formatting

Add missing folder structure for samples and src in solution file

34847f2

Refactor sampleApp for consistency and readability; update access mod…

0dba733

…ifiers and formatting across multiple files

MykhailoDav requested review from Copilot and yurkinh November 26, 2025 13:57

MykhailoDav assigned yurkinh Nov 26, 2025

Copilot started reviewing on behalf of MykhailoDav November 26, 2025 13:58 View session

Copilot finished reviewing on behalf of MykhailoDav November 26, 2025 13:59

Copilot AI reviewed Nov 26, 2025

View reviewed changes

Copilot AI mentioned this pull request Nov 26, 2025

Replace Debug.WriteLine with Trace.WriteLine per project best practices #15

Closed

MykhailoDav and others added 9 commits November 26, 2025 16:53

Update src/Plugin.Maui.SegmentedControl/Control/SegmentedControlOptio…

84013d9

…n.cs Co-authored-by: Copilot <[email protected]>

Update .github/copilot-instructions.md

a57abb3

Co-authored-by: Copilot <[email protected]>

Update .github/copilot-instructions.md

afff04a

Co-authored-by: Copilot <[email protected]>

Fix access modifier for List2 and remove unnecessary line in SegContr…

a6afefa

…olTest1 constructor

Merge branch 'Refactors' of https://github.com/yurkinh/Plugin.Maui.Se…

d24b1d5

…gmentedControl into Refactors

Update .github/copilot-instructions.md

151d4a3

Co-authored-by: Copilot <[email protected]>

Refactor conditional statements for clarity in SegControlTest1 and Te…

5f28780

…st2ViewModel

Replace Debug.WriteLine with Trace.WriteLine in SegmentedControlOptio…

c037594

…n constructor for improved logging consistency

Merge branch 'Refactors' of https://github.com/yurkinh/Plugin.Maui.Se…

f1f185d

…gmentedControl into Refactors

yurkinh requested a review from Copilot November 26, 2025 17:01

Copilot started reviewing on behalf of yurkinh November 26, 2025 17:01 View session

Copilot finished reviewing on behalf of yurkinh November 26, 2025 17:03

Copilot AI reviewed Nov 26, 2025

View reviewed changes

Initial plan

c6c417c

Copilot AI mentioned this pull request Nov 26, 2025

[WIP] Address feedback from review on some refactors PR #16

Merged

7 tasks

Initial plan

ee80270

Copilot AI mentioned this pull request Nov 26, 2025

Verify removal of private modifiers in Test2ViewModel.cs #17

Merged

Initial plan

1d8cea0

This was referenced Nov 26, 2025

No changes needed - typo already corrected #18

Merged

Remove private keywords from field declarations #19

Merged

Initial plan

753239d

Copilot AI mentioned this pull request Nov 26, 2025

Remove private keyword from fields per coding guidelines #20

Merged

Initial plan

9e09531

Copilot AI mentioned this pull request Nov 26, 2025

Address coding guidelines feedback - private modifiers already removed #21

Merged

Initial plan

3a55e66

Copilot AI mentioned this pull request Nov 26, 2025

Remove private modifiers per coding guidelines #22

Merged

Copilot AI and others added 10 commits November 26, 2025 17:10

Remove private keywords from SegmentedControlOption fields

5daf086

Co-authored-by: yurkinh <[email protected]>

Remove private modifiers from fields in SegmentedControlOption.cs per…

5076e06

… coding guidelines Co-authored-by: yurkinh <[email protected]>

Remove private modifiers per coding guidelines

a89c46b

Co-authored-by: yurkinh <[email protected]>

Merge pull request #20 from yurkinh/copilot/sub-pr-14-one-more-time

63a0d41

Remove private keyword from fields per coding guidelines

Merge pull request #16 from yurkinh/copilot/sub-pr-14-again

11133ad

[WIP] Address feedback from review on some refactors PR

Remove private modifiers from fields and methods per coding guidelines

ecd9c16

Co-authored-by: yurkinh <[email protected]>

Merge pull request #22 from yurkinh/copilot/sub-pr-14-05684bed-8209-4…

df72d7d

…d75-8222-2696c59534da Remove private modifiers per coding guidelines

Merge pull request #18 from yurkinh/copilot/sub-pr-14-yet-again

384b8ff

No changes needed - typo already corrected

Merge pull request #17 from yurkinh/copilot/sub-pr-14-another-one

4900769

Verify removal of private modifiers in Test2ViewModel.cs

Merge pull request #21 from yurkinh/copilot/sub-pr-14-please-work

f885d42

Address coding guidelines feedback - private modifiers already removed

yurkinh merged commit 4ffb63a into main Nov 26, 2025

Some refactors #14

Some refactors #14

Uh oh!

Conversation

MykhailoDav commented Nov 26, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI commented Nov 26, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Nov 26, 2025

Choose a reason for hiding this comment

Uh oh!

yurkinh Nov 26, 2025

Choose a reason for hiding this comment

Uh oh!

yurkinh Nov 26, 2025

Choose a reason for hiding this comment

Uh oh!

yurkinh Nov 26, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 26, 2025

Choose a reason for hiding this comment

Uh oh!

yurkinh Nov 26, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI Nov 26, 2025

Choose a reason for hiding this comment

Uh oh!

yurkinh Nov 26, 2025

Choose a reason for hiding this comment

Uh oh!

yurkinh Nov 26, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI commented Nov 26, 2025

Uh oh!

Copilot AI commented Nov 26, 2025

Uh oh!

Copilot AI commented Nov 26, 2025

Uh oh!

Copilot AI commented Nov 26, 2025

Uh oh!

Copilot AI commented Nov 26, 2025

Uh oh!

Copilot AI commented Nov 26, 2025

Uh oh!

Copilot AI commented Nov 26, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants