Add FontSize and Padding properties to SegmentedControl #11

Copilot · 2025-11-18T14:09:12Z

The control lacked basic text styling properties, forcing text to use hardcoded sizes and rendering with no spacing from borders.

Changes

Added properties
- FontSize (double, default 14.0) - controls segment text size
- Padding (Thickness, default 0) - adds spacing around segment content
Android
- Removed hardcoded 12sp from RadioButton layout
- Map FontSize via SetTextSize() with sp units
- Map Padding via SetPadding() with pixel conversion
iOS/MacCatalyst
- Apply FontSize through UIStringAttributes.Font for both states
- Apply Padding via SetContentPositionAdjustment()

Usage

<controls:SegmentedControl 
    FontSize="16" 
    Padding="10,5,10,5"
    TintColor="#007AFF">
  <controls:SegmentedControl.Children>
    <controls:SegmentedControlOption Text="Tab 1" />
    <controls:SegmentedControlOption Text="Tab 2" />
  </controls:SegmentedControl.Children>
</controls:SegmentedControl>

Fixes Missing a bunch of styling properties #8

Original prompt

This section details on the original issue you should resolve

<issue_title>Missing a bunch of styling properties</issue_title>
<issue_description>As the title already says, this control lacks a bunch of styling options. It seems like there is no way to set Padding or FontSize for example even tho the control displays text. This way, the text of the control has a different size then everything else in the app and without a padding option for the options, the text is stuck to it's borders which looks ugly. </issue_description>

Comments on the Issue (you are @copilot in this section)

Fixes Missing a bunch of styling properties #8

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Co-authored-by: yurkinh <17849938+yurkinh@users.noreply.github.com>

MykhailoDav · 2025-11-25T16:47:05Z

@copilot 'UISegmentedControl' does not contain a definition for 'ContentOffset' and no accessible extension method 'ContentOffset' accepting a first argument of type 'UISegmentedControl' could be found (are you missing a using directive or an assembly reference?)

Copilot

Pull request overview

This PR adds essential text styling capabilities to the SegmentedControl by introducing FontSize and Padding properties, addressing the limitation where text was previously hardcoded and lacked spacing from borders.

Added FontSize property (double, default 14.0) for controlling segment text size
Added Padding property (Thickness, default 0) for spacing around segment content
Implemented platform-specific handlers for Android, iOS, and MacCatalyst with appropriate native mappings

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 6 comments.

Show a summary per file

File	Description
src/Plugin.Maui.SegmentedControl/Control/ISegmentedControl.cs	Added FontSize and Padding property declarations to the interface
src/Plugin.Maui.SegmentedControl/Control/SegmentedControl.cs	Defined BindableProperty for FontSize and Padding with default values
src/Plugin.Maui.SegmentedControl/Platforms/iOS/SegmentedControlHandler.cs	Implemented font size via UIStringAttributes.Font and padding via ContentOffset for iOS
src/Plugin.Maui.SegmentedControl/Platforms/MacCatalyst/SegmentedControlHandler.cs	Implemented font size via UIStringAttributes.Font and padding via ContentOffset for MacCatalyst
src/Plugin.Maui.SegmentedControl/Platforms/Android/SegmentedControlHandler.cs	Implemented font size via SetTextSize with sp units and padding via SetPadding with pixel conversion
src/Plugin.Maui.SegmentedControl/Platforms/Android/Resources/layout/RadioButton.axml	Removed hardcoded 12sp textSize to enable dynamic font sizing
samples/Test.SegmentedControl/MainPage.xaml	Added example usage demonstrating FontSize="16" and Padding="10,5,10,5"
README.md	Documented new FontSize and Padding properties with descriptions and default values

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-11-25T16:48:46Z

src/Plugin.Maui.SegmentedControl/Platforms/iOS/SegmentedControlHandler.cs

+        if (OperatingSystem.IsIOSVersionAtLeast(14, 0) || OperatingSystem.IsMacCatalystVersionAtLeast(14, 0))
+        {
+            handler.PlatformView.Layer.MasksToBounds = false;
+            handler.PlatformView.ContentOffset = new CoreGraphics.CGSize(padding.Left - padding.Right, padding.Top - padding.Bottom);


ContentOffset is intended to shift the content within segments, not to implement padding. Using ContentOffset with (padding.Left - padding.Right, padding.Top - padding.Bottom) will offset content in unexpected ways when padding values differ (e.g., left=10, right=5 produces an offset of 5, not traditional padding). This approach may not provide the expected padding behavior. Consider using UIEdgeInsets via contentEdgeInsets if available, or document this limitation clearly.

Suggested change

if (OperatingSystem.IsIOSVersionAtLeast(14, 0) || OperatingSystem.IsMacCatalystVersionAtLeast(14, 0))

{

handler.PlatformView.Layer.MasksToBounds = false;

handler.PlatformView.ContentOffset = new CoreGraphics.CGSize(padding.Left - padding.Right, padding.Top - padding.Bottom);

// Use ContentEdgeInsets if available (iOS 15+), otherwise do nothing.

if (OperatingSystem.IsIOSVersionAtLeast(15, 0) || OperatingSystem.IsMacCatalystVersionAtLeast(15, 0))

{

handler.PlatformView.Layer.MasksToBounds = false;

handler.PlatformView.ContentEdgeInsets = new UIEdgeInsets(padding.Top, padding.Left, padding.Bottom, padding.Right);

Copilot · 2025-11-25T16:48:46Z

src/Plugin.Maui.SegmentedControl/Platforms/MacCatalyst/SegmentedControlHandler.cs

+        if (OperatingSystem.IsIOSVersionAtLeast(14, 0) || OperatingSystem.IsMacCatalystVersionAtLeast(14, 0))
+        {
+            segmentControl.Layer.MasksToBounds = false;
+            segmentControl.ContentOffset = new CoreGraphics.CGSize(padding.Left - padding.Right, padding.Top - padding.Bottom);


ContentOffset is intended to shift the content within segments, not to implement padding. Using ContentOffset with (padding.Left - padding.Right, padding.Top - padding.Bottom) will offset content in unexpected ways when padding values differ (e.g., left=10, right=5 produces an offset of 5, not traditional padding). This approach may not provide the expected padding behavior. Consider using UIEdgeInsets via contentEdgeInsets if available, or document this limitation clearly.

Suggested change

if (OperatingSystem.IsIOSVersionAtLeast(14, 0) || OperatingSystem.IsMacCatalystVersionAtLeast(14, 0))

{

segmentControl.Layer.MasksToBounds = false;

segmentControl.ContentOffset = new CoreGraphics.CGSize(padding.Left - padding.Right, padding.Top - padding.Bottom);

if (OperatingSystem.IsIOSVersionAtLeast(13, 0) || OperatingSystem.IsMacCatalystVersionAtLeast(13, 0))

{

segmentControl.Layer.MasksToBounds = false;

segmentControl.ContentEdgeInsets = new UIEdgeInsets((nfloat)padding.Top, (nfloat)padding.Left, (nfloat)padding.Bottom, (nfloat)padding.Right);

Copilot · 2025-11-25T16:48:47Z

src/Plugin.Maui.SegmentedControl/Platforms/MacCatalyst/SegmentedControlHandler.cs

+        if (OperatingSystem.IsIOSVersionAtLeast(14, 0) || OperatingSystem.IsMacCatalystVersionAtLeast(14, 0))
+        {
+            handler.PlatformView.Layer.MasksToBounds = false;
+            handler.PlatformView.ContentOffset = new CoreGraphics.CGSize(padding.Left - padding.Right, padding.Top - padding.Bottom);


ContentOffset is intended to shift the content within segments, not to implement padding. Using ContentOffset with (padding.Left - padding.Right, padding.Top - padding.Bottom) will offset content in unexpected ways when padding values differ (e.g., left=10, right=5 produces an offset of 5, not traditional padding). This approach may not provide the expected padding behavior. Consider using UIEdgeInsets via contentEdgeInsets if available, or document this limitation clearly.

Suggested change

handler.PlatformView.ContentOffset = new CoreGraphics.CGSize(padding.Left - padding.Right, padding.Top - padding.Bottom);

handler.PlatformView.ContentEdgeInsets = new UIEdgeInsets((nfloat)padding.Top, (nfloat)padding.Left, (nfloat)padding.Bottom, (nfloat)padding.Right);

Copilot · 2025-11-25T16:48:47Z

src/Plugin.Maui.SegmentedControl/Platforms/iOS/SegmentedControlHandler.cs

    static void MapSelectedTextColor(SegmentedControlHandler handler, SegmentedControl control)
    {
-        handler.PlatformView.SetTitleTextAttributes(new UIStringAttributes() { ForegroundColor = control.SelectedTextColor.ToPlatform() }, UIControlState.Selected);        
+        var font = UIKit.UIFont.SystemFontOfSize((nfloat)control.FontSize);
+        handler.PlatformView.SetTitleTextAttributes(new UIStringAttributes() 
+        { 
+            ForegroundColor = control.SelectedTextColor.ToPlatform(),
+            Font = font
+        }, UIControlState.Selected);        
    }

    static void MapTextColor(SegmentedControlHandler handler, SegmentedControl control)
    {
-        handler.PlatformView.SetTitleTextAttributes(new UIStringAttributes() { ForegroundColor = control.TextColor.ToPlatform() }, UIControlState.Normal);
+        var font = UIKit.UIFont.SystemFontOfSize((nfloat)control.FontSize);
+        handler.PlatformView.SetTitleTextAttributes(new UIStringAttributes() 
+        { 
+            ForegroundColor = control.TextColor.ToPlatform(),
+            Font = font
+        }, UIControlState.Normal);
+    }
+
+    static void MapFontSize(SegmentedControlHandler handler, SegmentedControl control)
+    {
+        var font = UIKit.UIFont.SystemFontOfSize((nfloat)control.FontSize);
+        handler.PlatformView.SetTitleTextAttributes(new UIStringAttributes() 
+        { 
+            ForegroundColor = control.SelectedTextColor.ToPlatform(),
+            Font = font
+        }, UIControlState.Selected);
+        handler.PlatformView.SetTitleTextAttributes(new UIStringAttributes() 
+        { 
+            ForegroundColor = control.TextColor.ToPlatform(),
+            Font = font
+        }, UIControlState.Normal);
+    }


[nitpick] There's significant code duplication between MapFontSize, MapSelectedTextColor, and MapTextColor methods. All three methods create the same font object and call SetTitleTextAttributes with nearly identical code. Consider extracting a helper method like UpdateTitleTextAttributes() that applies both color and font for all states to reduce duplication and make maintenance easier.

Copilot · 2025-11-25T16:48:47Z

src/Plugin.Maui.SegmentedControl/Platforms/MacCatalyst/SegmentedControlHandler.cs

    static void MapSelectedTextColor(SegmentedControlHandler handler, SegmentedControl control)
    {
-        handler.PlatformView.SetTitleTextAttributes(new UIStringAttributes() { ForegroundColor = control.SelectedTextColor.ToPlatform() }, UIControlState.Selected);
+        var font = UIKit.UIFont.SystemFontOfSize((nfloat)control.FontSize);
+        handler.PlatformView.SetTitleTextAttributes(new UIStringAttributes() 
+        { 
+            ForegroundColor = control.SelectedTextColor.ToPlatform(),
+            Font = font
+        }, UIControlState.Selected);
    }

    static void MapTextColor(SegmentedControlHandler handler, SegmentedControl control)
    {
-        handler.PlatformView.SetTitleTextAttributes(new UIStringAttributes() { ForegroundColor = control.TextColor.ToPlatform() }, UIControlState.Normal);
+        var font = UIKit.UIFont.SystemFontOfSize((nfloat)control.FontSize);
+        handler.PlatformView.SetTitleTextAttributes(new UIStringAttributes() 
+        { 
+            ForegroundColor = control.TextColor.ToPlatform(),
+            Font = font
+        }, UIControlState.Normal);
+    }
+
+    static void MapFontSize(SegmentedControlHandler handler, SegmentedControl control)
+    {
+        var font = UIKit.UIFont.SystemFontOfSize((nfloat)control.FontSize);
+        handler.PlatformView.SetTitleTextAttributes(new UIStringAttributes() 
+        { 
+            ForegroundColor = control.SelectedTextColor.ToPlatform(),
+            Font = font
+        }, UIControlState.Selected);
+        handler.PlatformView.SetTitleTextAttributes(new UIStringAttributes() 
+        { 
+            ForegroundColor = control.TextColor.ToPlatform(),
+            Font = font
+        }, UIControlState.Normal);
+    }


[nitpick] There's significant code duplication between MapFontSize, MapSelectedTextColor, and MapTextColor methods. All three methods create the same font object and call SetTitleTextAttributes with nearly identical code. Consider extracting a helper method like UpdateTitleTextAttributes() that applies both color and font for all states to reduce duplication and make maintenance easier.

Copilot · 2025-11-25T16:48:47Z

src/Plugin.Maui.SegmentedControl/Platforms/iOS/SegmentedControlHandler.cs

+        if (OperatingSystem.IsIOSVersionAtLeast(14, 0) || OperatingSystem.IsMacCatalystVersionAtLeast(14, 0))
+        {
+            segmentControl.Layer.MasksToBounds = false;
+            segmentControl.ContentOffset = new CoreGraphics.CGSize(padding.Left - padding.Right, padding.Top - padding.Bottom);


ContentOffset is intended to shift the content within segments, not to implement padding. Using ContentOffset with (padding.Left - padding.Right, padding.Top - padding.Bottom) will offset content in unexpected ways when padding values differ (e.g., left=10, right=5 produces an offset of 5, not traditional padding). This approach may not provide the expected padding behavior. Consider using UIEdgeInsets via contentEdgeInsets if available, or document this limitation clearly.

Suggested change

segmentControl.ContentOffset = new CoreGraphics.CGSize(padding.Left - padding.Right, padding.Top - padding.Bottom);

segmentControl.ContentEdgeInsets = new UIEdgeInsets((nfloat)padding.Top, (nfloat)padding.Left, (nfloat)padding.Bottom, (nfloat)padding.Right);

…tPositionAdjustment Co-authored-by: MykhailoDav <155299608+MykhailoDav@users.noreply.github.com>

Copilot · 2025-11-25T16:50:19Z

@copilot 'UISegmentedControl' does not contain a definition for 'ContentOffset' and no accessible extension method 'ContentOffset' accepting a first argument of type 'UISegmentedControl' could be foun...

Fixed in de5c038. Replaced ContentOffset (which doesn't exist on UISegmentedControl) with SetContentPositionAdjustment() for iOS and MacCatalyst padding support.

Copilot AI self-assigned this Nov 18, 2025

Initial plan

79e0a81

Copilot AI assigned yurkinh Nov 18, 2025

Copilot started work on behalf of yurkinh November 18, 2025 14:09 View session

Add FontSize and Padding properties to SegmentedControl

b6fad2f

Co-authored-by: yurkinh <17849938+yurkinh@users.noreply.github.com>

Copilot AI changed the title ~~[WIP] Add missing styling properties for control~~ Add FontSize and Padding properties to SegmentedControl Nov 18, 2025

Copilot AI requested a review from yurkinh November 18, 2025 14:24

Copilot finished work on behalf of yurkinh November 18, 2025 14:24

MykhailoDav requested review from MykhailoDav and Copilot November 25, 2025 16:44

MykhailoDav self-assigned this Nov 25, 2025

Copilot started reviewing on behalf of MykhailoDav November 25, 2025 16:45 View session

Copilot finished reviewing on behalf of MykhailoDav November 25, 2025 16:47

Copilot started work on behalf of MykhailoDav November 25, 2025 16:47 View session

Copilot AI reviewed Nov 25, 2025

View reviewed changes

Fix iOS/MacCatalyst build error: Replace ContentOffset with SetConten…

de5c038

…tPositionAdjustment Co-authored-by: MykhailoDav <155299608+MykhailoDav@users.noreply.github.com>

Copilot finished work on behalf of MykhailoDav November 25, 2025 16:54

fixes

55ade5d

MykhailoDav marked this pull request as ready for review November 25, 2025 18:56

MykhailoDav merged commit c20d2a2 into main Nov 25, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add FontSize and Padding properties to SegmentedControl #11

Add FontSize and Padding properties to SegmentedControl #11

Uh oh!

Copilot AI commented Nov 18, 2025 •

edited

Loading

Uh oh!

MykhailoDav commented Nov 25, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Nov 25, 2025

Uh oh!

Copilot AI Nov 25, 2025

Uh oh!

Copilot AI Nov 25, 2025

Uh oh!

Copilot AI Nov 25, 2025

Uh oh!

Copilot AI Nov 25, 2025

Uh oh!

Copilot AI Nov 25, 2025

Uh oh!

Copilot AI commented Nov 25, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

	handler.PlatformView.ContentOffset = new CoreGraphics.CGSize(padding.Left - padding.Right, padding.Top - padding.Bottom);
	handler.PlatformView.ContentEdgeInsets = new UIEdgeInsets((nfloat)padding.Top, (nfloat)padding.Left, (nfloat)padding.Bottom, (nfloat)padding.Right);

	segmentControl.ContentOffset = new CoreGraphics.CGSize(padding.Left - padding.Right, padding.Top - padding.Bottom);
	segmentControl.ContentEdgeInsets = new UIEdgeInsets((nfloat)padding.Top, (nfloat)padding.Left, (nfloat)padding.Bottom, (nfloat)padding.Right);

Add FontSize and Padding properties to SegmentedControl #11

Add FontSize and Padding properties to SegmentedControl #11

Uh oh!

Conversation

Copilot AI commented Nov 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

Usage

Comments on the Issue (you are @copilot in this section)

Uh oh!

MykhailoDav commented Nov 25, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Nov 25, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 25, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 25, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 25, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 25, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 25, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI commented Nov 25, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Copilot AI commented Nov 18, 2025 •

edited

Loading