Skip to content

Conversation

@GarrettS
Copy link

I just added changes from /src. Did I get the pull request right this time?

@yahoocla
Copy link

CLA is valid!

@caridy
Copy link
Member

caridy commented Apr 10, 2014

Hey @GarrettS you're getting there. At least I can see your changes (3 files), but your commit is including things that are not needed in the PR, specifically, you committed the build folder, and it seems that you also did a wrong build within the src/build folder. You should probably update this PR or just issue a new one. The trick is: check the diff before submitting the PR, you should see only 3 files:

src/dd/js/drop.js
src/dd/tests/unit/assets/dd-tests.js
src/dd/tests/unit/index.html

which is what your change is all about, if you see something else, it is just adding noise for us to review it and merge it. does that makes sense?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants