refactor(ActionBarIcon): extract onClick logic to setup

[inottn]

Before submitting a pull request, please read the contributing guide.

在提交 pull request 之前，请阅读 贡献指南。

[gemini-code-assist]

Summary of Changes

Hello @inottn, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the ActionBarIcon component by relocating its click event handling logic. The onClick function has been moved from being defined within the component's render function to the setup function, which is a standard practice for optimizing performance and ensuring event handlers are stable across re-renders.

Highlights

• Refactoring onClick Logic: The onClick event handler for the ActionBarIcon component has been extracted from the render function and moved into the setup function scope.
• Performance Improvement: This change optimizes component performance by ensuring the event handler is defined once during component setup, preventing its recreation on every re-render cycle.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request effectively refactors the onClick logic in ActionBarIcon.tsx by moving it from the render function into the setup function, which is a good practice for Vue 3 Composition API, improving performance and maintainability. However, the navigation logic remains vulnerable to Cross-Site Scripting (XSS) via the url prop, which is used in a dangerous way by the underlying route utility. Implementing URL sanitization is recommended to mitigate this risk.

[gemini-code-assist]

The onClick handler calls the route() function, which eventually sets location.href using the url prop. If the url prop contains a javascript: URI, it can lead to Cross-Site Scripting (XSS). Although this is a common pattern in UI libraries, it is recommended to sanitize the URL to prevent execution of malicious scripts.

    const onClick = () => {
      if (!props.disabled) {
        if (props.url && /^\s*javascript:/i.test(props.url)) {
          return;
        }
        route();
      }
    };

[codecov-commenter]

Codecov Report

❌ Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.94%. Comparing base (ec5b45b) to head (712ff75).
⚠️ Report is 201 commits behind head on main.

Files with missing lines	Patch %	Lines
...ackages/vant/src/action-bar-icon/ActionBarIcon.tsx	66.66%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #13762      +/-   ##
==========================================
+ Coverage   89.60%   89.94%   +0.34%     
==========================================
  Files         257      257              
  Lines        7013     7054      +41     
  Branches     1736     1749      +13     
==========================================
+ Hits         6284     6345      +61     
+ Misses        384      372      -12     
+ Partials      345      337       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.