Skip to content

Exposed the camera clock setting #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gkostov wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Exposed the camera clock setting #70

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions examples/AsyncCam/handlers.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ static const char FRONTPAGE[] = R"EOT(
%vflip%
%rawGma%
%lensCorrection%
%xclk%
<input type="submit" value="update">
</p></form>
<p id="controls">
Expand Down Expand Up @@ -138,6 +139,7 @@ rewriteFrontpage(const esp32cam::Settings& s, const String& var) {
SHOW_INT(brightness, -2, 2)
SHOW_INT(contrast, -2, 2)
SHOW_INT(saturation, -2, 2)
SHOW_INT(xclk, 6, 24)
SHOW_BOOL(hmirror)
SHOW_BOOL(vflip)
SHOW_BOOL(rawGma)
Expand Down Expand Up @@ -166,6 +168,7 @@ handleUpdate(AsyncWebServerRequest* req) {
SAVE_INT(gain);
SAVE_INT(lightMode);
SAVE_INT(specialEffect);
SAVE_INT(xclk);
SAVE_BOOL(hmirror);
SAVE_BOOL(vflip);
SAVE_BOOL(rawGma);
Expand Down
12 changes: 12 additions & 0 deletions src/esp32cam/config.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,6 +112,7 @@ CameraClass::status() const {
result.vflip = ss.vflip != 0;
result.rawGma = ss.raw_gma != 0;
result.lensCorrection = ss.lenc != 0;
result.xclk = sensor->xclk_freq_hz / 1000000U;
return result;
}

Expand Down Expand Up @@ -155,6 +156,7 @@ CameraClass::update(const Settings& settings, int sleepFor) {
CHECK_RANGE(lightMode, -1, 4);
CHECK_RANGE(specialEffect, 0, 6);
CHECK_RANGE(gain, -128, 31);
CHECK_RANGE(xclk, 6, 24);

UPDATE3(framesize, settings.resolution.as<framesize_t>(), framesize_t);
UPDATE1(brightness);
Expand Down Expand Up @@ -184,6 +186,16 @@ CameraClass::update(const Settings& settings, int sleepFor) {
UPDATE2(wb_mode, settings.lightMode);
}

int prev = sensor->xclk_freq_hz / 1000000U, desired = settings.xclk;
if (prev != desired) {
int res = sensor->set_xclk(sensor, LEDC_TIMER_0, desired);
ESP32CAM_LOG("update xclk %d => %d %s", prev, desired,
res == 0 ? "success" : "failure");
if (res != 0) {
return false;
}
}

#undef CHECK_RANGE
#undef UPDATE4
#undef UPDATE3
Expand Down
3 changes: 3 additions & 0 deletions src/esp32cam/config.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,9 @@ struct Settings {
* - AGC enabled: -2,-4,-8,-16,-32,-64,-128, which corresponds to 2x ~ 128x gain.
*/
int8_t gain;

/** @brief Camera clock value in MHz. Recommended to be between 6 and 24. */
int8_t xclk;

/** @brief Image light mode. */
LightMode lightMode;
Expand Down