Refactor BitbakeDriver to be editor agnostic #420
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To refactor BitbakeDriver to become editor agnostic, add BitbakeDriverVSCode which will be the base for factoring out VSCode specific functionality from BitbakeDriver.
To make BitbakeDriver editor agnostic, change the notifications from a VSCode dependent implementation to the standard logging and override it to clientNotificationManager in BitbakeDriverVSCode.
To make the BitbakeDriver editor agnostic, replace runBitbakeTerminalCustomCommand with a generic runTerminalCommand function that gets overriden by runBitbakeTerminalCustomCommand in BitbakeDriverVSCode.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Factoring out VSCode specific functionality from BitbakeDriver to BitbakeDriverVSCode.
I would love some input on how I factored out runBitbakeTerminalCustomCommand, I don't currently love exactly how I did it.
I made the default behaviour of runTerminalCommand to be a noop since it needs to be implemented by a subclass to make sense. This solution also forces the client to implement their own queuing/locking logic for running terminal commands which I am also not too pleased about.
I also though about making it an abstract function that only gets implemented in a subclass but then that would require making BitbakeDriver an abstract class which seemed like too big of a change to me.
Some next steps after this would be moving it to one of the lib folders.
Thanks!