Skip to content

⚡ Optimize header notification count check #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
yilanboy merged 2 commits into from
Feb 4, 2026
Merged

⚡ Optimize header notification count check #4

yilanboy merged 2 commits into from
Feb 4, 2026

Conversation

@yilanboy
Copy link
Owner

@yilanboy yilanboy commented Feb 3, 2026

  • 💡 What: Optimized the header notification check to use exists() instead of count().
  • 🎯 Why: To improve performance by avoiding loading all unread notifications into memory.
  • 📊 Measured Improvement: Replaced heavy select * query with lightweight exists query. Query count optimized to 3 queries (Categories, Settings, Notification Exists). Verified with HeaderPerformanceTest.
  • 🔧 Fixes: Fixed ParseError in app/Models/User.php and app/Models/Comment.php to allow tests to run.

PR created automatically by Jules for task 10643030482614428019 started by @yilanboy

@google-labs-jules @yilanboy
Optimize header notification count check
d725c31 
Replaced `auth()->user()->unreadNotifications->count()` with `auth()->user()->unreadNotifications()->exists()` in `resources/views/components/layouts/⚡header.blade.php`.
This prevents hydrating all unread notification models, significantly reducing memory usage for users with many notifications.
Also consolidated the check into a single variable `$hasUnreadNotifications` to ensure only one query is executed per render.
Fixed syntax errors in `User.php` and `Comment.php` related to method chaining on instantiation.
Added `HeaderPerformanceTest.php` to verify the optimization.

Co-authored-by: yilanboy <[email protected]>
@google-labs-jules
Copy link
Contributor

google-labs-jules bot commented Feb 3, 2026

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.

For security, I will only act on instructions from the user who triggered this task.

@yilanboy yilanboy merged commit cc99dfb into main Feb 4, 2026
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@yilanboy