Skip to content

Conversation

Copy link

Copilot AI commented Dec 11, 2025

Q A
Is bugfix?
New feature?
Breaks BC? ✔️
Fixed issues

Renames the $addFilterHandlers constructor parameter to $extraFilterHandlers in QueryDataReader for clarity.

Changes:

  • Renamed constructor parameter from $addFilterHandlers to $extraFilterHandlers
  • Updated PHPDoc @psalm-param annotation
  • Updated internal usage in spread operator

Breaking Change:
Code passing this parameter by name must update:

// Before
new QueryDataReader($query, addFilterHandlers: $handlers);

// After
new QueryDataReader($query, extraFilterHandlers: $handlers);

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Copy link
Author

Copilot AI commented Dec 11, 2025

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • https://api.github.com/repos/colinodell/json5/zipball/15b063f8cb5e6deb15f0cd39123264ec0d19c710
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/qjrWp2 /usr/bin/composer install st.php ndor/bin/grep user.name (http block)
  • https://api.github.com/repos/reactphp/stream/zipball/1e5b0acb8fe55143b5b426817155190eb6f5b18d
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/qjrWp2 /usr/bin/composer install st.php ndor/bin/grep user.name (http block)
  • https://api.github.com/repos/symfony/polyfill-mbstring/zipball/6d857f4d76bd4b343eac26d6b539585d2bc56493
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/qjrWp2 /usr/bin/composer install st.php ndor/bin/grep user.name (http block)

If you need me to access, download, or install something from one of these locations, you can either:

Copilot AI changed the title [WIP] Rename addFilterHandlers to extraFilterHandlers Rename addFilterHandlers to extraFilterHandlers Dec 11, 2025
Copilot AI requested a review from vjik December 11, 2025 11:07
@codecov
Copy link

codecov bot commented Dec 11, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.72%. Comparing base (87b97df) to head (43ada2c).
⚠️ Report is 1 commits behind head on adapt-data.

Additional details and impacted files
@@              Coverage Diff              @@
##             adapt-data     #124   +/-   ##
=============================================
  Coverage         97.72%   97.72%           
  Complexity           92       92           
=============================================
  Files                22       22           
  Lines               264      264           
=============================================
  Hits                258      258           
  Misses                6        6           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@vjik vjik marked this pull request as ready for review December 11, 2025 11:27
@vjik vjik merged commit ab4a087 into adapt-data Dec 11, 2025
73 checks passed
@vjik vjik deleted the copilot/sub-pr-123 branch December 11, 2025 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants