-
-
Notifications
You must be signed in to change notification settings - Fork 3
Introduce field mapper #110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
vjik
commented
Sep 4, 2025
| Q | A |
|---|---|
| Is bugfix? | ❌ |
| New feature? | ✔️ |
| Breaks BC? | ✔️ |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #110 +/- ##
==============================================
- Coverage 100.00% 76.61% -23.39%
- Complexity 90 98 +8
==============================================
Files 21 22 +1
Lines 271 295 +24
==============================================
- Hits 271 226 -45
- Misses 0 69 +69 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
samdark
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Need docs.
|
|
||
| public function map(string $field): string|ExpressionInterface | ||
| { | ||
| return $this->map[$field] ?? $field; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should it return new ColumnName() if the value is string?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think, no. Yii DB quote string values
Co-authored-by: Sergei Tigrov <[email protected]>