Remove exported internal functions#1908
Open
spencerjanssen wants to merge 1 commit intoyesodweb:masterfrom
Open
Remove exported internal functions#1908spencerjanssen wants to merge 1 commit intoyesodweb:masterfrom
spencerjanssen wants to merge 1 commit intoyesodweb:masterfrom
Conversation
Fixes yesodweb#1907 The exports were introduced in 9c445b6 and released in yesod-core 1.6.29.0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1907
The PVP says removing these exports requires a major version bump, but it seems fine to bend the rules here with a minor version bump. Alternatively this PR could be bundled with a future major release.
Before submitting your PR, check that you've:
After submitting your PR: