Conversation
0a575b0 to
a32ef0f
Compare
|
CI failure seems unrelated to this PR..? 🤔 |
Vlix
left a comment
There was a problem hiding this comment.
PR looks fine in principle. Though it might have to be a major version bump, since the API for KilledByThreadManager has changed. (And there's an extra constraint on stopAfter)
Also, the CI failures are indeed because of this PR. threadLabel is only available from base-4.18 onward. So we'll need something like the following to make it build on older GHCs.
#if MIN_VERSION_base(4,18,0)
mLabel <- threadLabel tid
#else
let mLabel = Nothing
#endif(and of course some CPP at the import of threadLabel)
|
Oh! I'm so sorry, this included changes that I didn't intend to include. Sincere apologies, I will roll those back and leave only |
a32ef0f to
4454dc3
Compare
|
@Vlix Ok, I've force-pushed to the branch, leaving only |
Geen probleem, kan gebeuren 👍 Addition is short and to the point, passes all checks, I see nothing wrong with this. |
|
Dank je wel! :) |
Before submitting your PR, check that you've:
@sincedeclarations to the HaddockAfter submitting your PR: