Skip to content

Introduce stopAfterWithResult#1069

Open
edsko wants to merge 1 commit intoyesodweb:masterfrom
edsko:edsko/stopAfterWithResult
Open

Introduce stopAfterWithResult#1069
edsko wants to merge 1 commit intoyesodweb:masterfrom
edsko:edsko/stopAfterWithResult

Conversation

@edsko
Copy link
Copy Markdown
Contributor

@edsko edsko commented Mar 28, 2026

Before submitting your PR, check that you've:

After submitting your PR:

  • Update the Changelog.md file with a link to your PR
  • Check that CI passes (or if it fails, for reasons unrelated to your change, like CI timeouts)

@edsko
Copy link
Copy Markdown
Contributor Author

edsko commented Mar 28, 2026

CI failure seems unrelated to this PR..? 🤔

Copy link
Copy Markdown
Contributor

@Vlix Vlix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR looks fine in principle. Though it might have to be a major version bump, since the API for KilledByThreadManager has changed. (And there's an extra constraint on stopAfter)

Also, the CI failures are indeed because of this PR. threadLabel is only available from base-4.18 onward. So we'll need something like the following to make it build on older GHCs.

#if MIN_VERSION_base(4,18,0)
    mLabel <- threadLabel tid
#else
    let mLabel = Nothing
#endif

(and of course some CPP at the import of threadLabel)

@edsko
Copy link
Copy Markdown
Contributor Author

edsko commented Mar 31, 2026

Oh! I'm so sorry, this included changes that I didn't intend to include. Sincere apologies, I will roll those back and leave only stopAfterWithResult.

@edsko edsko force-pushed the edsko/stopAfterWithResult branch from a32ef0f to 4454dc3 Compare March 31, 2026 14:23
@edsko
Copy link
Copy Markdown
Contributor Author

edsko commented Mar 31, 2026

@Vlix Ok, I've force-pushed to the branch, leaving only stopAfterWithResult, which does not introduce any backwards incompatible changes. Apologies again, I clearly should not have submitted this PR at the end of a long working week 😅

@Vlix
Copy link
Copy Markdown
Contributor

Vlix commented Mar 31, 2026

Apologies again, I clearly should not have submitted this PR at the end of a long working week 😅

Geen probleem, kan gebeuren 👍


Addition is short and to the point, passes all checks, I see nothing wrong with this.
I will probably merge and publish somewhere at the end of the week.

@edsko
Copy link
Copy Markdown
Contributor Author

edsko commented Apr 1, 2026

Dank je wel! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants