merge queue: embarking master (f2bc885) and #1801 together #1804
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Python 3.14, `urljoin('file:', '/some/path')` returns
`file:/some/path`, which is not accepted by gopls as a valid URL.
Apparently, `urljoin('file://', '/some/path')` works correctly in all
Python versions, so let's try it.
Signed-off-by: Dmitry Tantsur <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨ Pull request #1801 which was ahead in the queue has been dequeued (for the following reason:
checks failed). ✨Branch master (f2bc885) and #1801 are embarked together for merge.
This pull request has been created by Mergify to speculatively check the mergeability of #1801.
You don't need to do anything. Mergify will close this pull request automatically when it is complete.
Required conditions of queue
duplicated default from Manual merge on Azure Pipelines and Maintainer Overridefor merge:status-success=macos-14 - test runstatus-success=ubuntu-24.04 - test runstatus-success=C++ Lintstatus-success=macos-14 - C++ Benchmarkstatus-success=ubuntu-24.04 - C++ Benchmarkstatus-success=ubuntu-24.04 - with Clang compiler - test runstatus-success=ubuntu-24.04 - without libclang completer - test runRequired conditions to stay in the queue:
#approved-reviews-by>=1#changes-requested-reviews-by=0base=masterlabel="Ship It!"status-success=C++ Lintstatus-success=macos-14 - C++ Benchmarkstatus-success=macos-14 - test runstatus-success=ubuntu-24.04 - C++ Benchmarkstatus-success=ubuntu-24.04 - test runstatus-success=ubuntu-24.04 - with Clang compiler - test runstatus-success=ubuntu-24.04 - without libclang completer - test runThis change is