Skip mono check on Linux with .NET 6.0 #1751
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkaszews
force-pushed
the
linux-mono-net6
branch
from
4ebe019 to
846d52b
Compare
Collaborator
|
Thanks a lot for the contributing, especially to this part of the codebase. Me and puremourning have had a discussion recently, concerning the future of C# support in ycmd. Long story short, it's about switching to LSP, but I'd like to ask you to hop over to gitter for a chat. |
ycmd/completers/cs/cs_completer.py
Outdated
|
|
||
| if ( not utils.OnWindows() | ||
| and self._roslyn_path.endswith( '.exe' ) ): | ||
| if ( MonoRequired( self._roslyn_path ) ): |
puremourning
approved these changes
Dec 12, 2025
Member
puremourning
left a comment
puremourning
left a comment
There was a problem hiding this comment.
@puremourning reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: 1 of 2 LGTMs obtained (waiting on @dkaszews)
dkaszews
commented
Dec 12, 2025
Contributor
Author
dkaszews
left a comment
dkaszews
left a comment
There was a problem hiding this comment.
Reviewable status:
complete! 2 of 2 LGTMs obtained (waiting on @dkaszews)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1750
This change is