Add logger #68
Open
Add logger #68
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plantfansam
force-pushed
the
add-logger
branch
from
11962e4 to
b5472d8
Compare
yangxikun
requested changes
Feb 11, 2023
| -- | ||
| -- @return nil | ||
| function _M:write(message, configured_level, callsite_level) | ||
| if configured_level >= self:log_levels()[callsite_level] then |
Owner
There was a problem hiding this comment.
Can we just use self.log_level here, instead of configured_level ?
Contributor
Author
There was a problem hiding this comment.
sorry for the delay on this, I will try to make this change!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
❗ this PR contains commits from #67. To view the diff of just this PR, you can look at this link. ❗
This PR adds a base logger that allows the package to work in contexts outside of openresty, along with an nginx logger — configured by default — that maintains the library's current behavior.