add pr checklist urvy d #1288
Open
add pr checklist urvy d #1288
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The tough-cookie v5.x dependency pulled by @cypress/request uses optional chaining syntax (?.) which is not supported in Node.js 8. This was causing a SyntaxError during test execution. Pin tough-cookie to v2.5.0 which is compatible with Node.js 8.
…TvP9z Fix Node.js 8 compatibility by pinning tough-cookie version
This commit addresses several issues in the codebase: - Fix unpinAllGeneralForumTopicMessages calling wrong API method Previously called 'unhideGeneralForumTopic', now correctly calls 'unpinAllGeneralForumTopicMessages' - Fix replaceStickerInSet calling wrong API method Previously called 'deleteStickerFromSet', now correctly calls 'replaceStickerInSet' - Fix memory leak in reply listeners Reply listeners are now automatically removed after being triggered, preventing unbounded memory growth in long-running bots - Use safe hasOwnProperty check Replace direct obj.hasOwnProperty() with Object.prototype.hasOwnProperty.call() to avoid issues with objects that may not have this method - Fix variable name typo Rename 'businesssMessage' to 'businessMessage' for consistency - Fix spelling errors in comments Correct 'miliseconds' to 'milliseconds' and 'occured' to 'occurred'
…ons-LM946 Fix critical bugs and improve code quality
Reflects spelling corrections from source files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
npm run docDescription
This PR consolidates bug fixes and code quality improvements:
Bug Fixes:
unpinAllGeneralForumTopicMessages(was incorrectly callingunhideGeneralForumTopic)replaceStickerInSet(was incorrectly callingdeleteStickerFromSet)businesssMessage→businessMessageObject.prototype.hasOwnProperty.call()pattern instead of directhasOwnPropertyCompatibility:
Documentation:
References