Add configurable PRINT card values to Struct2XAS.make_input_feff#606
Open
hcenge wants to merge 2 commits intoxraypy:masterfrom
Open
Add configurable PRINT card values to Struct2XAS.make_input_feff#606hcenge wants to merge 2 commits intoxraypy:masterfrom
hcenge wants to merge 2 commits intoxraypy:masterfrom
Conversation
Add feff_print parameter to control FEFF output verbosity for each module (pot, xsph, fms, paths, genfmt, ff2chi). Default [1,0,0,0,0,3] matches structure2feff.py behavior. Backwards compatible - users can pass custom values if needed.
Tests verify: - Default feff_print produces [1,0,0,0,0,3] (ff2chi=3) - Custom feff_print values are applied correctly - Old behavior (ff2chi=0) is recoverable for backwards compatibility
Member
|
@hcenge thanks for proposing this improvement. I may merge this, but we are moving all the FEFF/FDMNES input generation to a separate project, Larixite. I have created a task for it #607. In fact, Would you be interested in trying Larixite and contribute there? If yes, please note that |
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Using
Struct2XASto generate FEFF paths for EXAFS fitting requires the individualfeffNNNN.datfiles. This requiresff2chi=3in the PRINT card, but it was hardcoded to 0 in the template filefeff_exafs.tmpl.structure2feff.pyalready defaults toff2chi=3, so this change makesstruct2xas.pyconsistent while letting users override if needed.Changes
feff_printparameter tomake_input_feff()(default[1,0,0,0,0,3])feff_exafs.tmplto use placeholders for the feff PRINT output parameterstests/test_struct2xas_feff_print.pyUsage
Old behavior is recoverable by passing
feff_print=[1,0,0,0,0,0]