Open
Conversation
Collaborator
Author
|
This PR has now a first version ready. Can some of you read the notebook and tell me what they think about it ? I fixed the issue I had and I can recover parameters quite nicely. |
thjsal
reviewed
Jan 24, 2026
|
|
||
| Added interface of the emission models to the ``Likelihood`` and ``Signal``. | ||
|
|
||
| Added a ``reset`` option to the Signal registration, which is by default ``True`` and execute the same as before. The option ``reset=False`` is useful for emission models. No newline at end of file |
Contributor
There was a problem hiding this comment.
Could you please describe what does the "reset" option do? If setting it to False, registering will add a new signal to the old one, instead of overwriting the old. Is that the idea? I am though still not sure why/how does it work.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I implemented a framework to add any model to X-PSI, even ones that would need to be embedded in the metric. Such models can have parameters that are fitted alongside the usual models.
Alongside this, I provide a Powerlaw model, that can be pulsed or not. I managed to fit some data with this model. I can maybe add some other basics models if needed, such as a Gaussian or different pulsation definitions ?
Should I make a new notebook to explain it, or simply add a section to the Modeling/XPSI101 notebooks ?
Closes #625