0.6.1/Auth Client #6
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: LingKa <[email protected]>
Signed-off-by: LingKa <[email protected]>
Signed-off-by: LingKa <[email protected]>
Signed-off-by: LingKa <[email protected]>
Signed-off-by: LingKa <[email protected]>
Signed-off-by: LingKa <[email protected]>
Signed-off-by: LingKa <[email protected]>
Signed-off-by: LingKa <[email protected]>
Signed-off-by: LingKa <[email protected]>
Signed-off-by: iGxnon <[email protected]>
Signed-off-by: iGxnon <[email protected]>
Signed-off-by: iGxnon <[email protected]>
bsbds
reviewed
Feb 5, 2024
Comment on lines
+39
to
+44
| public AuthenticateResponse authenticate(AuthenticateRequest req) throws InvalidProtocolBufferException, CommandExecutionException { | ||
| RequestWithToken reqToken = RequestWithToken.newBuilder().setToken(this.token).setAuthenticateRequest(req).build(); | ||
| Command cmd = Command.newBuilder().setRequest(reqToken).build(); | ||
| CommandResponse resp = this.curpClient.propose(cmd, false); | ||
| return resp.getAuthenticateResponse(); | ||
| } |
Collaborator
There was a problem hiding this comment.
The authenticate operation does need to set token.
| public AuthUserGetResponse userGet(AuthUserGetRequest req) throws InvalidProtocolBufferException, CommandExecutionException { | ||
| RequestWithToken reqToken = RequestWithToken.newBuilder().setToken(this.token).setAuthUserGetRequest(req).build(); | ||
| Command cmd = Command.newBuilder().setRequest(reqToken).build(); | ||
| CommandResponse resp = this.curpClient.propose(cmd, false); |
Collaborator
There was a problem hiding this comment.
userGet and roleGet could use fast path.
| return resp.getAuthenticateResponse(); | ||
| } | ||
|
|
||
| public AuthUserAddResponse userAdd(AuthUserAddRequest req) throws InvalidProtocolBufferException, CommandExecutionException { |
Collaborator
There was a problem hiding this comment.
Please hash the password in userAdd and userChangePassword
Contributor
Author
|
Close because unused, see #7 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Base on #5
Please briefly answer these questions:
Add auth client
Add auth client
No