CA-421077: Some small logging cleanups #321
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise the installer logs a message like: ... Installer Version b'11.1.2-1.xs9' Signed-off-by: Ross Lagerwall <[email protected]>
Using runCmd2() means that every iteration is logged, including the "help" output. Switch to using subprocess directly to silence the log spam. Signed-off-by: Ross Lagerwall <[email protected]>
Using -B causes multipath to treat the binding file as read-only but the file doesn't exist when first booting the install environment which causes multipath to log an error and exit with status 1. Since it is on a tmpfs and it is not copied into the installed system, it should be fine to write to the bindings file so just drop the -B switch. Signed-off-by: Ross Lagerwall <[email protected]>
alexbrett
approved these changes
Jan 9, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.