Skip to content

core: use ConstantLike + HasFolderInterface for constant op results#5660

Merged
superlopuh merged 1 commit intomainfrom
sasha/core/get-constant
Feb 13, 2026
Merged

core: use ConstantLike + HasFolderInterface for constant op results#5660
superlopuh merged 1 commit intomainfrom
sasha/core/get-constant

Conversation

@superlopuh
Copy link
Member

This more closely resembles the MLIR API, where ConstantLike is a trait, and ops have optional folders.

This more closely resembles the MLIR API, where ConstantLike is a trait, and ops have optional folders.
@superlopuh superlopuh requested a review from jumerckx February 13, 2026 17:25
@superlopuh superlopuh self-assigned this Feb 13, 2026
@superlopuh superlopuh added the core xDSL core (ir, textual format, ...) label Feb 13, 2026
@codecov
Copy link

codecov bot commented Feb 13, 2026

Codecov Report

❌ Patch coverage is 98.03922% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 86.26%. Comparing base (2ec6429) to head (3b0637e).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
xdsl/dialects/equivalence.py 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5660      +/-   ##
==========================================
- Coverage   86.26%   86.26%   -0.01%     
==========================================
  Files         403      403              
  Lines       56881    56867      -14     
  Branches     6565     6564       -1     
==========================================
- Hits        49068    49054      -14     
- Misses       6282     6283       +1     
+ Partials     1531     1530       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@superlopuh superlopuh merged commit d432e76 into main Feb 13, 2026
23 checks passed
@superlopuh superlopuh deleted the sasha/core/get-constant branch February 13, 2026 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core xDSL core (ir, textual format, ...)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants