Skip to content

dialect: (rv64) add rv64.GetRegisterOp#5657

Open
osmanyasar05 wants to merge 8 commits intoxdslproject:mainfrom
osmanyasar05:rv64/zero
Open

dialect: (rv64) add rv64.GetRegisterOp#5657
osmanyasar05 wants to merge 8 commits intoxdslproject:mainfrom
osmanyasar05:rv64/zero

Conversation

@osmanyasar05
Copy link
Contributor

This PR introduces rv64.GetRegisterOp operation to rv64 dialect.

@codecov
Copy link

codecov bot commented Feb 12, 2026

Codecov Report

❌ Patch coverage is 90.90909% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 86.25%. Comparing base (9a3c91b) to head (5ea0eec).

Files with missing lines Patch % Lines
xdsl/transforms/canonicalization_patterns/riscv.py 85.71% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5657   +/-   ##
=======================================
  Coverage   86.25%   86.25%           
=======================================
  Files         403      403           
  Lines       56852    56859    +7     
  Branches     6556     6558    +2     
=======================================
+ Hits        49038    49046    +8     
+ Misses       6283     6282    -1     
  Partials     1531     1531           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Co-authored-by: Sasha Lopoukhine <superlopuh@gmail.com>
@superlopuh superlopuh added the dialects Changes on the dialects label Feb 12, 2026
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could not make sure how to duplicate this for rv64. should we create a new folder /tests/backend/rv{32/64}?
one option could be just creating 2 new files, tests/backend/riscv/test_preallocated_rv{32/64}.py ?

Copy link
Member

@superlopuh superlopuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic, thank you

@superlopuh superlopuh self-requested a review February 13, 2026 17:36
@superlopuh
Copy link
Member

Code looks good, happy to approve once CI is fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dialects Changes on the dialects

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants