-
Notifications
You must be signed in to change notification settings - Fork 143
frontend: (pyast) support classmethods #5595
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
30556a9 to
3f197df
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5595 +/- ##
=======================================
Coverage 86.15% 86.15%
=======================================
Files 392 393 +1
Lines 56271 56333 +62
Branches 6485 6496 +11
=======================================
+ Hits 48478 48535 +57
- Misses 6261 6264 +3
- Partials 1532 1534 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@superlopuh How critical is code coverage? I suppose the missing else branch could be covered by trying to call something that is neither a function nor classmethod |
3f197df to
93b0a7c
Compare
superlopuh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! Thank you
This adds
classmethodsupport to Python code generation so that we can now write e.g. the following instead of having to create a wrapper function: