-
-
Notifications
You must be signed in to change notification settings - Fork 2
feat: bump versions and fix when no respones are received from VF #63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Caution Review failedThe pull request is closed. WalkthroughMultiple CI workflows update the checkout action to Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20–30 minutes
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 3
🧹 Nitpick comments (1)
pkg/voiceflow/interact.go (1)
79-83: Improved error detail is helpful; consider small refinementsIncluding the raw response body in the unmarshal error is useful for diagnosing bad/malformed responses. A couple of optional tweaks you might consider:
- Avoid the extra
[]byte(string(body))conversion and unmarshal directly frombody:err = json.Unmarshal(body, &interactions)- Optionally add HTTP status to the error to quickly spot non‑2xx responses:
return nil, fmt.Errorf("error unmarshalling response (status %d): %w; body: %s", res.StatusCode, err, string(body))- If the API can return very large payloads, you may want to truncate
bodyin the error message to keep logs readable.These are non-blocking and can be deferred.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
go.sumis excluded by!**/*.sum
📒 Files selected for processing (13)
.github/workflows/build.yml(1 hunks).github/workflows/codeql.yml(1 hunks).github/workflows/depsreview.yaml(1 hunks).github/workflows/grype.yml(1 hunks).github/workflows/lint.yaml(1 hunks).github/workflows/master.yml(1 hunks).github/workflows/publish-docs.yaml(1 hunks).github/workflows/release_build.yml(2 hunks).gitignore(1 hunks).vscode/launch.json(1 hunks)go.mod(3 hunks)pkg/test/runner.go(2 hunks)pkg/voiceflow/interact.go(1 hunks)
🧰 Additional context used
🧬 Code graph analysis (2)
pkg/test/runner.go (1)
internal/types/tests/testTypes.go (1)
VariableConfig(56-59)
pkg/voiceflow/interact.go (1)
internal/types/voiceflow/interact/interactResponseTypes.go (1)
InteractionResponse(3-6)
🪛 GitHub Actions: golangci-lint
pkg/test/runner.go
[error] 170-170: QF1003: could use tagged switch on validation.Type (staticcheck)
🪛 GitHub Check: lint
pkg/test/runner.go
[failure] 170-170:
QF1003: could use tagged switch on validation.Type (staticcheck)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Summary
🔇 Additional comments (11)
.gitignore (1)
50-51: Thevoiceflow-cliignore pattern does not hide project source files.This is the
xavidop/voiceflow-clirepository, where the root itself is the project. The ignore patternvoiceflow-clitargets a directory at the repository root level, which would not match the actual source code located in./internal/,./pkg/,.github/, etc. The pattern aligns with other build artifact entries likedist/,completions/, andmanpages/, suggesting it ignores generated or build output. The existing entryvoiceflow-cli/chocofurther suggests a build artifact directory structure (possibly Chocolatey packaging). No action required..vscode/launch.json (1)
131-131: Confirm server port alignment across toolingChanging the debug launch port to 8081 is fine, but please confirm your local server actually listens on 8081 and that any docs/scripts (README, Makefile, etc.) are updated accordingly so dev workflows stay consistent.
.github/workflows/master.yml (1)
15-15: Checkout v6 upgrade looks consistentUsing
actions/checkout@v6here is consistent with the rest of the workflows and should be fine; just ensure this version matches what you expect for your GitHub-hosted or self-hosted runners..github/workflows/grype.yml (1)
20-20: Grype workflow checkout bump is fineThe switch to
actions/checkout@v6under thescan-sourcejob aligns with other workflows and keeps the YAML structure valid..github/workflows/build.yml (1)
18-18: Build workflow checkout upgrade looks goodThe upgrade to
actions/checkout@v6in the build workflow matches the other workflows and should not change behavior beyond using the newer action version..github/workflows/lint.yaml (1)
23-23: Lint workflow now aligned on checkout v6Using
actions/checkout@v6here keeps this workflow in sync with the others; no issues spotted with the step ordering or permissions..github/workflows/codeql.yml (1)
18-18: CodeQL workflow checkout bump is safeThe switch to
actions/checkout@v6in the CodeQL workflow is consistent with the rest of the CI config and should be a drop‑in replacement.pkg/test/runner.go (1)
117-117: LGTM: Added exact_match validation type.The
exact_matchvalidation type is now supported and treated identically toequals. Both perform string equality checks.go.mod (1)
3-3: Go 1.24.0 was released on February 11, 2025 and is available for download. This explicit version specification is valid and poses no issues..github/workflows/publish-docs.yaml (1)
15-15: Verify actions/checkout@v6 breaking changes are not impacting this workflow.actions/checkout@v6 is available and stable, but introduces breaking changes from v5. Credentials are now persisted in a separate file under $RUNNER_TEMP instead of git config. Verify that:
- This workflow does not spawn sub-processes or use Docker container actions that rely on the token in git config
- Self-hosted runners (if used) meet the minimum version requirement (Actions Runner >= v2.329.0)
- Any scripts in the workflow that access git credentials have been updated accordingly
.github/workflows/release_build.yml (1)
33-33: Version v0.20.10 is valid and safe to use.The anchore/sbom-action/download-syft update from v0.20.6 to v0.20.10 is a standard patch-level bump released in November 2025. The version exists and updates Syft from v1.33.0 to v1.38.0, which includes dependency improvements and maintenance updates. No breaking changes are indicated.
Summary by CodeRabbit
New Features
Bug Fixes
Chores
✏️ Tip: You can customize this high-level summary in your review settings.