CP-54138: Sync SSH status during XAPI startup #6417
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LunfanZhang
force-pushed
the
private/luzhan/CP-54138
branch
from
52e4f7d to
ae8bd5f
Compare
robhoes
reviewed
Apr 11, 2025
gangj
reviewed
Apr 14, 2025
LunfanZhang
force-pushed
the
private/luzhan/CP-54138
branch
from
ae8bd5f to
b0afc92
Compare
gangj
reviewed
Apr 14, 2025
gangj
requested changes
Apr 14, 2025
Contributor
gangj
left a comment
gangj
left a comment
There was a problem hiding this comment.
Never leave ssh enabled unexpectedly.
- Ensure host.enabled_ssh reflects the actual SSH service state on startup, in case it was manually changed by the user. - Reschedule the "disable SSH" job if: - host.ssh_enabled_timeout is set to a positive value, and - host.ssh_expiry is in the future. - Disable the SSH if: - host.ssh_enabled_timeout is set to a positive value, and - host.ssh_expiry is in the past. Signed-off-by: Lunfan Zhang <[email protected]>
LunfanZhang
force-pushed
the
private/luzhan/CP-54138
branch
from
b0afc92 to
d077e3c
Compare
gangj
approved these changes
Apr 14, 2025
robhoes
approved these changes
Apr 16, 2025
gangj
merged commit 34b308c
into
xapi-project:feature/configure-ssh-phase2
17 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure
host.ssh_enabledreflects the actual SSH service state on startup, in case it was manually changed by the user.Reschedule the "disable SSH" job if:
host.ssh_enabled_timeoutis set to a positive value, andhost.ssh_expiryis in the future.