CP-53951: XAPI should not depend on libssl #6366
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
last-genius
approved these changes
Mar 18, 2025
Contributor
last-genius
left a comment
last-genius
left a comment
There was a problem hiding this comment.
If some command was used to automatically reformat the dune file, it should be noted in the commit message
Member
Author
My editor did it via LSP. Although this should be equivalent: We could also enable it globally in Added a note into the commit message. |
Vincent-lau
requested changes
Mar 18, 2025
lindig
approved these changes
Mar 18, 2025
Used `dune format-dune-file dune >x && mv x dune`. Can also be done via LSP. No functional change. Signed-off-by: Edwin Török <[email protected]>
XAPI dependended on vhd_lib, which depends on ssl and lwt. XAPI is not yet ready for Lwt (and mixing Lwt with blocking code is not a good idea). The library was only used to gain access to 1 variant used for parameter passing inside XAPI. Replace this with a polymorphic variant, and drop the dependency. Also allows to drop a match case that was dead code (proto was only ever set to NBD). Fixes: 044dc15 ("CP-45016: Add support for specifying nbd export in sparse_dd") Signed-off-by: Edwin Török <[email protected]>
Vincent-lau
approved these changes
Apr 8, 2025
Merged
via the queue into
xapi-project:master
with commit Apr 8, 2025
f51eba2
29 of 30 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It usually uses
stunnelfor that purpose, and we don't want XAPI to be affected by OpenSSL bugs directly.We can't completely drop openssl because sparse_dd relies on it, but that is a separate executable.