-
Notifications
You must be signed in to change notification settings - Fork 207
fix: if an error is caught, exit immediately #2478
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…hanging work is not acceptable.
WalkthroughThe catch block in the CLI's main entry point now awaits the telemetry shutdown function before exiting, rather than immediately setting the exit code. This ensures telemetry is properly flushed before the process terminates. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes 🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Comment |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2478 +/- ##
===========================================
- Coverage 63.20% 28.34% -34.87%
===========================================
Files 296 127 -169
Lines 41480 11144 -30336
Branches 4312 243 -4069
===========================================
- Hits 26219 3159 -23060
+ Misses 15239 7981 -7258
+ Partials 22 4 -18
🚀 New features to boost your workflow:
|
SkArchon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.
Checklist