Nominal support for v11 #422
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wtbarnes
added
the
compatibility
jacobdparker
force-pushed
the
v11-nominal-compatibility
branch
from
bdd55df to
a694c1a
Compare
Owner
Author
|
This pinning should work. There are two issues: 1. v0.10.2 of aiapy is broken and 2. v0.11 has some breaking changes, including only being compatible with 3.12 and above. This is really moot since I'm planning on just opening another PR right away to support only 3.12 and above anyway, but I just wanted things to pass on this PR first at least. |
Owner
Author
|
Hmm well based on the RTD builds looks like it is still broken. I think I'm just going to merge this as is as everything else seems to be passing and deal with this docs fail in a subsequent PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables fiasco to work with v11 by following the checklist here: https://fiasco.readthedocs.io/en/stable/developer.html#add-support-for-a-new-version-of-the-chianti-database
Note that this does not add some of features in the v11 software surrounding density-dependent rates.