Skip to content

Conversation

@massimodisidoro
Copy link

Fix mismatch in WRF time series WRITE format (with solar_diagnostics option activated).

TYPE: bug fix

KEYWORDS: time series, TS, format, write, wrf solar, solar_diagnostics

SOURCE: Massimo D'Isidoro (ENEA - Italian National Agency for New Technologies, Energy and Sustainable Economic Development)

DESCRIPTION OF CHANGES:
Problem:
When solar diagnostics is activated in namelist.input, the WRF time series output WRITE statement lists 55 variables but the Fortran FMT only specifies 54 fields. This causes the last variable (ts_swddnic2) to be written in a separate record in the output files *.TS , leading to inconsistent time series data.

Solution:
The WRITE statement FMT has been corrected to match all 55 variables, ensuring that they are written on the same record in the TS file.

ISSUE:
This fixes part of issue #2255

LIST OF MODIFIED FILES:
M share/wrf_timeseries.F

TESTS CONDUCTED:
A WRF run with solar_diagnostics activated, compared to previous version to confirm the fix.

RELEASE NOTE: Corrected a bug in the WRF time series output, when solar_diagnostics is activated, where the last variable (ts_swddnic2) was written in a separate record. TS files now correctly includes all the 55 variables on the same record.

@massimodisidoro massimodisidoro requested review from a team as code owners December 23, 2025 13:45
@weiwangncar
Copy link
Collaborator

The regression test results:

Test Type              | Expected  | Received |  Failed
= = = = = = = = = = = = = = = = = = = = = = = =  = = = =
Number of Tests        : 23           24
Number of Builds       : 60           57
Number of Simulations  : 158           150        0
Number of Comparisons  : 95           86        0

Failed Simulations are: 
None
Which comparisons are not bit-for-bit: 
None

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants