Skip to content

Conversation

@wosledon
Copy link
Owner

No description provided.

Copilot AI review requested due to automatic review settings November 24, 2025 02:56
@wosledon wosledon merged commit 23f97bc into main Nov 24, 2025
5 of 6 checks passed
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request introduces RAG (Retrieval Augmented Generation) capabilities to the Berry framework. It adds a complete vector storage and semantic search infrastructure with a MiniLM-L6-v2 embedding model implementation, enabling knowledge base retrieval and question-answering functionality.

Key Changes:

  • New vector storage module with in-memory implementation and embedding abstractions
  • RAG module providing document ingestion, semantic search, and conversation memory
  • MiniLM-L6-v2 embedding provider with ONNX runtime and tokenizer bridge
  • Complete RAG demo application showcasing the new capabilities

Reviewed changes

Copilot reviewed 57 out of 77 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/Berry.Modules.VectorStore/* Core vector storage module with in-memory implementation and interfaces
src/Berry.Modules.Rag/* RAG service providing query, ingestion, and hybrid retrieval with lexical boosting
src/Berry.Abstractions.Embeddings/* Embedding abstractions for provider, tokenizer, and model resolution
src/Berry.Embeddings.MiniLmL6v2/* MiniLM-L6-v2 implementation with ONNX runtime and tokenizer support
samples/Berry.RagDemo/* Demo application with REST API endpoints for document upload and semantic search
demos/RAGDemo/* Standalone CLI demo for local RAG experimentation
docs/develop/rag.md Documentation for RAG module usage and extension
docs/develop/embeddings.md Documentation for embeddings architecture and customization
Directory.Build.props Version bump to 1.0.3
Berry.slnx Solution file updated with new projects
Comments suppressed due to low confidence (2)

src/Berry.Embeddings.MiniLmL6v2/TokenizerBridge.cs:1

  • The comment references 'tokenizer.json' priority, but the PackageReference 'Tokenizers.DotNet' in the csproj may not be available or stable. Verify that this package exists and is compatible with net8.0, or provide fallback documentation if it's optional.
    samples/Berry.RagDemo/Controllers/RagController.cs:1
  • [nitpick] Complex logic compressed into a single line reduces readability. Consider breaking this into multiple lines with proper formatting for better maintainability.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants