retryablehttp: add test for context cancellation during retry backoff

[Falasefemi2]

This PR adds a test to verify that HttpClient.Do stops retrying
and returns context.Canceled if the request context is canceled
during the backoff sleep between retries.

It ensures the correct behavior and prevents potential goroutine/timer leaks.

[greptile-apps]

Greptile Summary

This PR adds a test (TestDo_ContextCanceledDuringRetry) to verify that the HttpClient.Do method properly stops retrying and returns context.Canceled when the request context is canceled during the backoff sleep between retries. The test uses a goroutine with channel synchronization to validate correct behavior and ensure no timer or goroutine leaks occur. The implementation in client.go already handles this case correctly with a select statement that checks for context cancellation during the backoff timer.

Confidence Score: 5/5

• This PR is safe to merge with no concerns. It adds a straightforward test for existing functionality without introducing any logic changes.
• Perfect score because: (1) The test is well-designed with proper goroutine synchronization using channels, (2) It correctly validates context cancellation behavior during retry backoff with appropriate timing, (3) The test assertions are correct and comprehensive, (4) No code changes to the production logic - only test additions, (5) The test follows existing patterns in the test file, (6) Context cancellation is properly handled with timer cleanup to prevent leaks.
• No files require special attention

Important Files Changed

Filename	Overview
pkg/retryablehttp/client_test.go	Test added to verify context cancellation during retry backoff. Uses goroutine pattern with channel synchronization to ensure proper cleanup and validates that context.Canceled error is returned when context is canceled during backoff sleep.

Sequence Diagram

sequenceDiagram
    participant Test
    participant Client as HttpClient.Do
    participant Server
    participant Timer
    participant Ctx as Context

    Test->>Client: client.Do(req) in goroutine
    Client->>Server: first request
    Server-->>Client: 500 Internal Server Error
    Client->>Client: shouldRetry = true
    Client->>Timer: Create timer for backoff
    Note over Timer: sleepTime ≈ 250-750ms
    Test->>Ctx: cancel() after 50ms
    Ctx-->>Client: Context.Done() triggered
    Client->>Timer: timer.Stop()
    Client-->>Test: return nil, context.Canceled
    Note over Test: Verify response is nil<br/>and error is context.Canceled

Loading

[greptile-apps]

_{1 file reviewed, no comments}

_{Edit Code Review Agent Settings | Greptile}