Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 43 additions & 0 deletions pkg/lint/rules.go
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,7 @@ var (
)

const gitCheckout = "git-checkout"
const sccacheEnable = "sccache/enable"

// AllRules is a list of all available rules to evaluate.
var AllRules = func(l *Linter) Rules { //nolint:gocyclo
Expand Down Expand Up @@ -527,6 +528,17 @@ var AllRules = func(l *Linter) Rules { //nolint:gocyclo
return nil
},
},
{
Name: "sccache-enabled",
Description: "sccache/enable is for local devel-use only",
Severity: SeverityError,
LintFunc: func(c config.Configuration) error {
if anyPipelineUses(c, sccacheEnable) {
return fmt.Errorf("scacche/enable pipeline exists")
}
return nil
},
},
{
Name: "valid-update-schedule",
Description: "update schedule config should contain a valid period",
Expand Down Expand Up @@ -630,6 +642,37 @@ func pickPipelinesUsing(uses string, pipelines []config.Pipeline) []*config.Pipe
return retval
}

func anyPipelineUses(c config.Configuration, uses string) bool {
for index := range len(c.Pipeline) {
if c.Pipeline[index].Uses == uses {
return true
}
}
if c.Test != nil {
for index := range len(c.Test.Pipeline) {
if c.Test.Pipeline[index].Uses == uses {
return true
}
}
}
for spindex := range c.Subpackages {
sp := c.Subpackages[spindex]
for index := range len(sp.Pipeline) {
if sp.Pipeline[index].Uses == uses {
return true
}
}
if sp.Test != nil {
for index := range len(sp.Test.Pipeline) {
if sp.Test.Pipeline[index].Uses == uses {
return true
}
}
}
}
return false
}

func containsKey(parentNode *yaml.Node, key string) error {
it := yit.FromNode(parentNode).
ValuesForMap(yit.WithValue(key), yit.All)
Expand Down