Added Sha3 ciphers to HMAC benchmark #113
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for SHA3-based HMAC algorithms in the benchmark, extends the test duration to 1 second, and refactors methods to obtain provider algorithms more universally.
- Added new HMAC algorithms ("HmacSHA224" and various "HmacSHA3-*" variants) with corresponding key sizes.
- Introduced universal methods for fetching algorithms from a provider and handling special cases (e.g., for "BC" and "SunJCE").
- Updated benchmark routines to run iterations based on elapsed time rather than a fixed iteration count.
jackctj117
force-pushed
the
MAC_bench
branch
3 times, most recently
from
67da09a to
60fd421
Compare
cconlon
approved these changes
Jun 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Sha3 ciphers to HMAC benchmark via dynamic algorithm search. As well as minor fix to MD test where two Sun results were showing up as negative.