feat(rad): new RadonInteger operators #2650
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guidiaz
changed the title
guidiaz
changed the title
guidiaz
force-pushed
the
feat/new-radon-integer-operators
branch
from
b78c193 to
1f79501
Compare
guidiaz
changed the title
aesedepece
requested changes
Sep 9, 2025
| } | ||
| } | ||
|
|
||
| pub fn to_bytes(input: RadonInteger) -> Result<RadonBytes, RadError> { |
Member
There was a problem hiding this comment.
I always assumed that an eventual Integer::to_bytes method would take the preferred endianness as an argument (even if we default to Big Endian)
@guidiaz What do you think?
| (RadonOpCodes::IntegerToBytes, None) => integer_operators::to_bytes(self.clone()) | ||
| .map(RadonTypes::from), | ||
| (RadonOpCodes::IntegerToFloat, None) => { | ||
| integer_operators::to_float(self.clone()).map(RadonTypes::from) |
Member
There was a problem hiding this comment.
We can stick to Into::into for uniformity:
Suggested change
| integer_operators::to_float(self.clone()).map(RadonTypes::from) | |
| integer_operators::to_float(self.clone()).map(Into::into) |
| } | ||
| } | ||
|
|
||
| pub fn to_bytes(input: RadonInteger) -> Result<RadonBytes, RadError> { |
Member
There was a problem hiding this comment.
In this case, it is better to receive the argument by reference to avoid redundant cloning:
Suggested change
| pub fn to_bytes(input: RadonInteger) -> Result<RadonBytes, RadError> { | |
| pub fn to_bytes(input: &RadonInteger) -> Result<RadonBytes, RadError> { |
I know you followed what to_float and to_string had in place, but that's not needed anymore with modern Rust 💪
Comment on lines
+24
to
+25
| let mut bytes_array = [0u8; 16]; | ||
| bytes_array.copy_from_slice(&input.value().to_be_bytes()); |
Member
There was a problem hiding this comment.
This should work just as well and benefit from lesser allocation and runtime:
Suggested change
| let mut bytes_array = [0u8; 16]; | |
| bytes_array.copy_from_slice(&input.value().to_be_bytes()); | |
| let bytes_array = input.value().to_be_bytes(); |
Member
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.