Transport version #316
Draft
Transport version #316
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
| __url__ = "https://github.com/wirepas/gateway" | ||
| __version__ = "1.6.0rc1" | ||
| __keywords__ = "wirepas connectivity iot mesh" | ||
|
|
Version can be now set via the WM_TRANSPORT_VERSION environment variable when building the python package. It defaults to a dev version. The PackageNotFoundError from importlib is not caught on purpose, to prevent silently setting an incorrect version in production. Bumping required python version due to importlib
Python packaging module (packaging.version.Version()) seems to be stripping the leading 'v' in the version so stripping it here might not be needed. However, doing it just in case and to be compliant with PEP 440.
sgunes-wirepas
force-pushed
the
transport_version
branch
from
182070f to
ea3b1a0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version can be set via the WM_TRANSPORT_VERSION environment variable when building the python package. It is 0.0.0.dev0 by default.
For releases and workflow_dispatch, tag is taken as it is with the v prefix removed. This means now a compliant version should be given for the workflow_dispatch tag and release tags.
For regular commits (push), 0.0.0.dev0.git+ version is used.