Conversation
…untime validation Annotated.Kind() delegates to Inner.Kind(), causing panics when code checks Kind() then does unsafe type assertions like m.(*Optional) on a value that is actually *Annotated wrapping an Optional. Unwrap Annotated before structural dispatch in union, optional, intersection construction and in subtype normalization and table type checking. Also add missing *typ.Interface case to runtime validateValue and validateWithErrorResolver so that bare `table` type annotations accept any LTable value.
When an LState was returned to the pool after a coroutine yield, the yielded field remained true. All three pool retrieval paths (resetLState, newLState, newLStateWithGAndAlloc) now clear it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.