The onboarding banner save has been moved to the database#8
Open
koltsov-spiralscout wants to merge 1 commit intomainfrom
Open
The onboarding banner save has been moved to the database#8koltsov-spiralscout wants to merge 1 commit intomainfrom
koltsov-spiralscout wants to merge 1 commit intomainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR migrates onboarding state management from localStorage to database persistence to ensure onboarding completion status is properly tracked across sessions and devices.
Key changes:
- Replaced localStorage reads/writes with API calls to
/api/v1/onboard/banner/flagsendpoint - Updated auto-redirect logic to rely solely on database-stored
hasVisitedflag - Modified all three onboarding state methods to use database persistence
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
koltsov-spiralscout
force-pushed
the
EE2-1894-need-to-hide-the-onboarding-banner
branch
from
9709fc3 to
e28aeca
Compare
koltsov-spiralscout
force-pushed
the
EE2-1894-need-to-hide-the-onboarding-banner
branch
from
e28aeca to
30ca89e
Compare
wolfy-j
approved these changes
Dec 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What’s fixed
After completing the onboarding flow, users still saw the "Begin" option, which made it appear as though the onboarding process wasn’t actually finished.
What was done
Replaced saving and reading onboarding state from localStorage with proper persistence in the database.
Updated logic to correctly reflect onboarding completion based on stored DB values.