Skip to content

Refactor sgs.get function to use sgs.get_json #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wilsonfreitas merged 1 commit into from
Apr 21, 2025
Merged

Refactor sgs.get function to use sgs.get_json #25

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 2 additions & 11 deletions bcb/sgs/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,17 +117,8 @@ def get(codes, start=None, end=None, last=0, multi=True, freq=None):
"""
dfs = []
for code in _codes(codes):
urd = _get_url_and_payload(code.value, start, end, last)
res = requests.get(urd["url"], params=urd["payload"])
if res.status_code != 200:
try:
res_json = json.loads(res.text)
except Exception:
res_json = {}
if "error" in res_json:
raise Exception("Download error: {}".format(res_json["error"]))
raise Exception("Download error: code = {}".format(code.value))
df = pd.read_json(StringIO(res.text))
text = get_json(code.value, start, end, last)
df = pd.read_json(StringIO(text))
df = _format_df(df, code, freq)
dfs.append(df)
if len(dfs) == 1:
Expand Down
13 changes: 0 additions & 13 deletions tests/sgs/test_series.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,19 +91,6 @@ def test_get_series():
assert x.index[-1] == datetime.strptime("2021-01-22", "%Y-%m-%d")


def test_get_long_series_error():
# Test for error when getting long series
try:
sgs.get(1, start="2000-01-01", end="2023-01-01")
except Exception as e:
assert (
str(e)
== "Download error: O sistema aceita uma janela de consulta de, no máximo, 10 anos em séries de periodicidade diária"
)
else:
assert False, "Expected an exception but none was raised."


def test_json_return():
# Test for JSON return
x = sgs.get_json(1, last=10)
Expand Down