Disable Mode 8 Export First PV Limit Clamp by Default #1731
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new clamping of PV limit in Mode 8 Export First mode requires further investigation. This is causing a ramp down oscillation of PV output due to the hysteresis setting. While under development, make the section of code default to disabled. See wills106#1730 for tracking of this.
When disabled, the log message can't find one of its arguments. Set it to the full pv limit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new clamping of PV limit in Mode 8 Export First mode requires further investigation. This is causing a ramp down oscillation of PV output due to the hysteresis setting.
As this is new logic not originally in this pathway, I'm proposing we make the section of code default to disabled until it has undergone further testing and development.
See #1730 for tracking of this.