Skip to content

Conversation

@l-olson1214
Copy link
Collaborator

@l-olson1214 l-olson1214 commented Jan 7, 2026

Phabricator:
https://phabricator.wikimedia.org/T409597

Notes

Test Steps

  1. On a logged in account with edits on the primary language
  2. Navigate to activity tab
  3. Scroll through to timeline to ensure edits are properly placed throughout (chronologically)
  4. Ensure you are able to tap into the edit to see the diff
  5. Ensure you do NOT see edits unless you're logged in
  6. Ensure you are unable to longpress/swipe on edit items, but can on the rest
  7. Look at cleanup and ensure it looks proper

Requirements:

-[x] Add edits into the timeline at the bottom of the Activity tab
-[x] Each edit includes a “View changes” leads to diff of your edit
-[x] Tapping on the article title should also lead you to the diff of your edit
-[x] Edits should be in chronological order, intermixed with articles read and saved
-[x] Edits should only be included in the timeline for logged-in users (temp accounts are treated like logged-out users)
-[x] It's acceptable to only have the past 500 edits represented in the timeline
-[x] No swipe option on edit items
-[x] No longpress option on edit items
-[x] Cleanup: Create a UserContributionsDataController, have it make the same call that YearInReviewEditCountSlideDataController does. Ask YearInReviewEditCountSlideDataController and YearInReviewDonateCountSlideDataController to fetch the data from UserContributionsDataController instead of making the call itself. Allow call to be made without a start/end date and with a maxlimit of 500.

Screenshots/Videos

Simulator Screenshot - iPhone 16 Plus - 2026-01-07 at 15 26 27
Simulator.Screen.Recording.-.iPhone.16.Plus.-.2026-01-07.at.15.35.17.mp4
simulator_screenshot_70D09120-3311-4342-AB84-1928A1B11EC8
Simulator.Screen.Recording.-.iPhone.16.Plus.-.2026-01-07.at.15.36.23.mp4

@l-olson1214 l-olson1214 requested review from a team and tonisevener and removed request for a team January 7, 2026 20:47
@l-olson1214 l-olson1214 marked this pull request as ready for review January 7, 2026 20:48
Copy link
Collaborator

@tonisevener tonisevener left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Most comments are about fixing changes resulting from my poor engineering notes in the task description.

One thing that feels like a bug to me is that the diff screen after pushing still shows the bottom tab bar.

Screenshot 2026-01-08 at 10 30 36 AM

The pattern in the rest of the app is to hide that tab bar upon any push from a root view. We generally play wack-a-mole for that. We have never pushed on this view directly from a root view before, in the past other views pushed on have already hidden the tab bar by the time the diff view is pushed.

To fix this one context, just add this to the end of the DiffContainerViewController init.

hidesBottomBarWhenPushed = true

@tonisevener tonisevener added the 7.8.11 Activity tab (add edits to timeline), HCaptcha, Thumbnails, Apple Pay bug, iPad search bug label Jan 12, 2026
@tonisevener tonisevener merged commit fcaaeff into main Jan 12, 2026
4 checks passed
@tonisevener tonisevener deleted the T409597_editing branch January 12, 2026 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

7.8.11 Activity tab (add edits to timeline), HCaptcha, Thumbnails, Apple Pay bug, iPad search bug

Development

Successfully merging this pull request may close these issues.

2 participants