-
-
Notifications
You must be signed in to change notification settings - Fork 843
T409597: Add editing to Activity Tab #5620
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
bb1e07e to
1470f7c
Compare
tonisevener
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Most comments are about fixing changes resulting from my poor engineering notes in the task description.
One thing that feels like a bug to me is that the diff screen after pushing still shows the bottom tab bar.
The pattern in the rest of the app is to hide that tab bar upon any push from a root view. We generally play wack-a-mole for that. We have never pushed on this view directly from a root view before, in the past other views pushed on have already hidden the tab bar by the time the diff view is pushed.
To fix this one context, just add this to the end of the DiffContainerViewController init.
hidesBottomBarWhenPushed = true
Phabricator:
https://phabricator.wikimedia.org/T409597
Notes
Test Steps
Requirements:
-[x] Add edits into the timeline at the bottom of the Activity tab
-[x] Each edit includes a “View changes” leads to diff of your edit
-[x] Tapping on the article title should also lead you to the diff of your edit
-[x] Edits should be in chronological order, intermixed with articles read and saved
-[x] Edits should only be included in the timeline for logged-in users (temp accounts are treated like logged-out users)
-[x] It's acceptable to only have the past 500 edits represented in the timeline
-[x] No swipe option on edit items
-[x] No longpress option on edit items
-[x] Cleanup: Create a UserContributionsDataController, have it make the same call that YearInReviewEditCountSlideDataController does. Ask YearInReviewEditCountSlideDataController and YearInReviewDonateCountSlideDataController to fetch the data from UserContributionsDataController instead of making the call itself. Allow call to be made without a start/end date and with a maxlimit of 500.
Screenshots/Videos
Simulator.Screen.Recording.-.iPhone.16.Plus.-.2026-01-07.at.15.35.17.mp4
Simulator.Screen.Recording.-.iPhone.16.Plus.-.2026-01-07.at.15.36.23.mp4