Skip to content

Conversation

@aarifsumra
Copy link
Contributor

Phabricator: https://phabricator.wikimedia.org/T408859

Notes

This PR Replaces the static lead image side length with a dynamic value based on wmf_listThumbnailWidthForScale. This ensures lead images are sized appropriately for different device screens.

As mention here

This (T408859) that for the talk page header it takes a static side length of 80 and asks for the retina scale (1,2,3), so 80, 160, 240; the expectation is that will be fixed to use the standard enum sizes mentioned above.

Test Steps

  1. Launch the app
  2. Open Any arcticle
  3. Tap on ... in the toolbar and open article talk page
  4. Observe the header

Screenshots/Videos

Before After

Replaces the static lead image side length with a dynamic value based on UIScreen scale and `wmf_listThumbnailWidthForScale`. This ensures lead images are sized appropriately for different device screens.
@aarifsumra aarifsumra marked this pull request as draft November 19, 2025 13:06
@aarifsumra aarifsumra marked this pull request as ready for review November 19, 2025 13:06
@aarifsumra
Copy link
Contributor Author

Hey @l-olson1214 , I am tagging you here as I am not able to get a reviewer assigned to this PR.
I went through contributions guidelines but I have no luck in finding how to assign the @ to review so it can auto send review request to the team.

@l-olson1214
Copy link
Collaborator

Hey @l-olson1214 , I am tagging you here as I am not able to get a reviewer assigned to this PR. I went through contributions guidelines but I have no luck in finding how to assign the @ to review so it can auto send review request to the team.

Hey @aarifsumra ! Thank you so much for submitting, I'll bring this to the team's attention :)!

@mazevedofs mazevedofs added the 7.8.7 Activity tab release label Nov 24, 2025
@tonisevener tonisevener removed the 7.8.7 Activity tab release label Dec 2, 2025
Copy link
Collaborator

@tonisevener tonisevener left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your PR @aarifsumra! Just one minor change needed.

horizontalStackView.addArrangedSubview(imageView)

let leadImageSideLength = CGFloat(TalkPageViewModel.leadImageSideLength)
let leadImageSideLength = CGFloat(UIScreen.main.wmf_listThumbnailWidthForScale().intValue)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For this task, I only want us to modify the way the thumbnail URL is created (which you are doing correctly in your TalkPageViewModel changes). This change here increases the size of the image view itself, so that it appears larger in your screenshot. Please revert this change here so that the size of the image view is unchanged. Thanks!

@aarifsumra
Copy link
Contributor Author

@tonisevener
I have updated the PR please review again :)

@tonisevener tonisevener added the 7.8.11 Activity tab (add edits to timeline), HCaptcha, Thumbnails, Apple Pay bug, iPad search bug label Jan 13, 2026
@tonisevener
Copy link
Collaborator

Thank you @aarifsumra!

@tonisevener tonisevener merged commit 8d84b76 into wikimedia:main Jan 13, 2026
4 of 5 checks passed
@aarifsumra aarifsumra deleted the T408859-Talk-page-header-image-thumb-size-WMFImageWidth branch January 23, 2026 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

7.8.11 Activity tab (add edits to timeline), HCaptcha, Thumbnails, Apple Pay bug, iPad search bug

Development

Successfully merging this pull request may close these issues.

4 participants