-
-
Notifications
You must be signed in to change notification settings - Fork 843
fix: Talk Page header image to use WMFImageWidth #5548
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Talk Page header image to use WMFImageWidth #5548
Conversation
Replaces the static lead image side length with a dynamic value based on UIScreen scale and `wmf_listThumbnailWidthForScale`. This ensures lead images are sized appropriately for different device screens.
|
Hey @l-olson1214 , I am tagging you here as I am not able to get a reviewer assigned to this PR. |
Hey @aarifsumra ! Thank you so much for submitting, I'll bring this to the team's attention :)! |
tonisevener
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your PR @aarifsumra! Just one minor change needed.
| horizontalStackView.addArrangedSubview(imageView) | ||
|
|
||
| let leadImageSideLength = CGFloat(TalkPageViewModel.leadImageSideLength) | ||
| let leadImageSideLength = CGFloat(UIScreen.main.wmf_listThumbnailWidthForScale().intValue) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For this task, I only want us to modify the way the thumbnail URL is created (which you are doing correctly in your TalkPageViewModel changes). This change here increases the size of the image view itself, so that it appears larger in your screenshot. Please revert this change here so that the size of the image view is unchanged. Thanks!
as per the recommended review
|
@tonisevener |
|
Thank you @aarifsumra! |
Phabricator: https://phabricator.wikimedia.org/T408859
Notes
This PR Replaces the static lead image side length with a dynamic value based on
wmf_listThumbnailWidthForScale. This ensures lead images are sized appropriately for different device screens.As mention here
Test Steps
Screenshots/Videos