Add config file option to set cdparanoia command #571
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves whipper-team#220 Partially addresses whipper-team#244 Provides workaround for whipper-team#234 Signed-off-by: Evan Harris <[email protected]>
eharris
force-pushed
the
config-opt-cdparanoia
branch
from
f623604 to
c7d02d3
Compare
Signed-off-by: Evan Harris <[email protected]>
Signed-off-by: Evan Harris <[email protected]>
Collaborator
|
Sorry for getting back to you so late on this, but I'm trying to help get these pull requests merged. I think the pull request looks fine, the only thing I don't quite like is the usage of 'global' to change the value of the variable in |
mweinelt
reviewed
Apr 23, 2024
| option = self._getDriveOption(vendor, model, release, 'defeats_cache') | ||
| return option == 'True' | ||
|
|
||
| def getCdparanoia(self, vendor, model, release): |
Contributor
There was a problem hiding this comment.
Suggested change
| def getCdparanoia(self, vendor, model, release): | |
| def getCdParanoia(self, vendor, model, release): |
Same casing as other instances.
Author
|
The global was necessary because the cdparanoia command is used in several places, so couldn't be restricted to just one module. Is there anything keeping this from getting merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows for setting the cdparanoia executable via the config file like so:
This does not allow for setting the option via the command line, as that would have required more extensive changes, since cdparanoia is used for multiple commands. But this does now allow for code to be added to make
whippersmarter and possibly able to detect and self-configure to use the best cdparanoia version, if multiple versions are available.Resolves #220
Partially addresses #244
Provides workaround for #234