media: properly restore onnegotiationneeded event handler #846
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 486e66a The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
pnts-se-whereby
force-pushed
the
pontus/cob-2399-restore-pc-negotiationneeded-handler-after-forced
branch
from
e3d75a2 to
8567371
Compare
Contributor
Author
|
/canary |
Contributor
|
🚀 The canary releases have been published to npm. You can test the releases by installing the newly published versions: pnpm add @whereby.com/[email protected]pnpm add @whereby.com/[email protected]pnpm add @whereby.com/[email protected]pnpm add @whereby.com/[email protected]pnpm add @whereby.com/[email protected] |
Contributor
Author
|
/canary |
Contributor
|
🚀 The canary releases have been published to npm. You can test the releases by installing the newly published versions: pnpm add @whereby.com/[email protected]pnpm add @whereby.com/[email protected]pnpm add @whereby.com/[email protected]pnpm add @whereby.com/[email protected]pnpm add @whereby.com/[email protected] |
pnts-se-whereby
changed the title
pnts-se-whereby
force-pushed
the
pontus/cob-2399-restore-pc-negotiationneeded-handler-after-forced
branch
from
8567371 to
f99b6cb
Compare
Contributor
Author
|
/canary |
Contributor
|
🚀 The canary releases have been published to npm. You can test the releases by installing the newly published versions: pnpm add @whereby.com/[email protected]pnpm add @whereby.com/[email protected]pnpm add @whereby.com/[email protected]pnpm add @whereby.com/[email protected]pnpm add @whereby.com/[email protected] |
pnts-se-whereby
force-pushed
the
pontus/cob-2399-restore-pc-negotiationneeded-handler-after-forced
branch
from
f99b6cb to
486e66a
Compare
havardholvik
approved these changes
Jan 19, 2026
Contributor
havardholvik
left a comment
havardholvik
left a comment
There was a problem hiding this comment.
Nice catch, and really nice cleanup. Regarding the constraints, shouldnt we just remove them if they are unused?
pnts-se-whereby
deleted the
pontus/cob-2399-restore-pc-negotiationneeded-handler-after-forced
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Summary:
Related Issue:
Testing
Screenshots/GIFs (if applicable)
Checklist
under the terms of the MIT license.
Additional Information