feat: add check for simplifiable match with sequence or mapping patterns#3560
Open
CommitToday wants to merge 2 commits intowemake-services:masterfrom
Conversation
Signed-off-by: SoulSniper1212 <warush23@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR adds a new check for simplifiable
matchstatements that use simple sequences or mappings (like lists or dicts with literal values). The check identifies when amatchstatement can be replaced with a simplerifstatement using equality comparison.Checklist
Proof
The new visitor
SimplifiableMatchWithSequenceOrMappingVisitorchecks formatchstatements that:case _:)When these conditions are met, it raises
SimplifiableMatchWithSequenceOrMappingViolationwith code 366. The test filetest_simplified_match_with_sequence_or_mapping.pyvalidates both simplifiable and non-simplifiable patterns.Closes #3527